Moodle
  1. Moodle
  2. MDL-31363

The GRADE_REPORT_AGGREGATION_VIEW constants seem to have no purpose

        Details

        • Type: Task Task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.2.1
        • Fix Version/s: 2.3
        • Component/s: Gradebook
        • Labels:
        • Database:
          Any
        • Testing Instructions:
          Hide

          Check that your site has debugging set to developer and is set to show error messages.

          In a course go to the grader, user and overview report. Check no errors are displayed.

          In the gradebook navigation go to My preferences > grader report.

          Alter "Show column averages" in some way and go back to the grader report. Check you are still getting no errors.

          Show
          Check that your site has debugging set to developer and is set to show error messages. In a course go to the grader, user and overview report. Check no errors are displayed. In the gradebook navigation go to My preferences > grader report. Alter "Show column averages" in some way and go back to the grader report. Check you are still getting no errors.
        • Affected Branches:
          MOODLE_22_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-31363_grade_constants
        • Pull Master Diff URL:
        • Rank:
          37880

          Description

          Are they useless? If so remove them. They dont seem to be used anywhere.

          define('GRADE_REPORT_AGGREGATION_VIEW_FULL', 0);
          define('GRADE_REPORT_AGGREGATION_VIEW_AGGREGATES_ONLY', 1);
          define('GRADE_REPORT_AGGREGATION_VIEW_GRADES_ONLY', 2);

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Andrew Davis added a comment -

            Adding a branch and test instructions.

            Although this a small change I feel like maybe it should only go into master. These constants are likely doing no harm in stable and there is a small chance that I'm wrong.

            Show
            Andrew Davis added a comment - Adding a branch and test instructions. Although this a small change I feel like maybe it should only go into master. These constants are likely doing no harm in stable and there is a small chance that I'm wrong.
            Hide
            Permalink
            Dan Poltawski added a comment -

            Agreed on the patch I can't see use indeed and your assessment for master only

            Show
            Dan Poltawski added a comment - Agreed on the patch I can't see use indeed and your assessment for master only
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Uhm, I've found some occurrences of those constants in contrib:

            • patches/LSU_gradebook
            • plugins/grade/report/stats
            • plugins/grade/report/visual

            But it seems to be outdated code, so applying this, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Uhm, I've found some occurrences of those constants in contrib: patches/LSU_gradebook plugins/grade/report/stats plugins/grade/report/visual But it seems to be outdated code, so applying this, thanks!
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            lol, conflicting with yourself... np.. resolving...

            Show
            Eloy Lafuente (stronk7) added a comment - lol, conflicting with yourself... np.. resolving...
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (master only)

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (master only)
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Passed based on followed testing instructions and in the no existence of uses across codebase. Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Passed based on followed testing instructions and in the no existence of uses across codebase. Ciao
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Well,

            I wish I said it every time
            you do the things you do.
            You always lend a helping hand,
            and I'm filled with gratitude.

            You are strong and generous
            for each and everyone one of us.
            I am eternally grateful,
            I cannot say thanks enough.

            Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: