Moodle

Typo in enrol_ldap.php

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.1
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: Language
  • Labels:
  • Testing Instructions:
    Hide

    run the following command on each patched branch and make sure a single line is returned:

    cat enrol/ldap/lang/en/enrol_ldap.php | grep "\['role_mapping'\] = '<p>For each role that"

    note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "role_mapping" string and make sure its value starts with "For each role that" string.

    Show
    run the following command on each patched branch and make sure a single line is returned: cat enrol/ldap/lang/en/enrol_ldap.php | grep "\['role_mapping'\] = '<p>For each role that" note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "role_mapping" string and make sure its value starts with "For each role that" string.
  • Affected Branches:
    MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    m_MDL-31388_fix_enrol_LDAP_typo
  • Pull Master Diff URL:

Description

enrol/ldap/lang/en/enrol_ldap.php:

$string['role_mapping'] = '<p>For each rol that you want to assign from LDAP ...

should read "For each role that ..."

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rajesh Taneja added a comment -

Patch looks good to me Gerry

Show
Rajesh Taneja added a comment - Patch looks good to me Gerry
Hide
Permalink
Gerard Caulfield added a comment -

Thanks Raj

Show
Gerard Caulfield added a comment - Thanks Raj
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Gerard Caulfield added a comment -

rebased

Show
Gerard Caulfield added a comment - rebased
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Gerry this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Gerry this has been integrated now.
Hide
Permalink
Ankit Agarwal added a comment -

works as expected!
passing
Thanks

Show
Ankit Agarwal added a comment - works as expected! passing Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Some changes to Moodle should be milestones in the project by themselves.

This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

Closing as fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: