Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      run the following command on each patched branch and make sure a single line is returned:

      cat enrol/ldap/lang/en/enrol_ldap.php | grep "\['role_mapping'\] = '<p>For each role that"

      note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "role_mapping" string and make sure its value starts with "For each role that" string.

      Show
      run the following command on each patched branch and make sure a single line is returned: cat enrol/ldap/lang/en/enrol_ldap.php | grep "\['role_mapping'\] = '<p>For each role that" note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "role_mapping" string and make sure its value starts with "For each role that" string.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-31388_fix_enrol_LDAP_typo

      Description

      enrol/ldap/lang/en/enrol_ldap.php:

      $string['role_mapping'] = '<p>For each rol that you want to assign from LDAP ...

      should read "For each role that ..."

        Gliffy Diagrams

          Activity

          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Patch looks good to me Gerry

          Show
          rajeshtaneja Rajesh Taneja added a comment - Patch looks good to me Gerry
          Hide
          gerry Gerard Caulfield added a comment -

          Thanks Raj

          Show
          gerry Gerard Caulfield added a comment - Thanks Raj
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          gerry Gerard Caulfield added a comment -

          rebased

          Show
          gerry Gerard Caulfield added a comment - rebased
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Gerry this has been integrated now.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Gerry this has been integrated now.
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          works as expected!
          passing
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - works as expected! passing Thanks
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Some changes to Moodle should be milestones in the project by themselves.

          This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

          Closing as fixed, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12