Moodle

Horizontal Scroll bar problem with Arabic Interface inside a Lesson

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.4, 2.2.1, 2.3
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: Lesson
  • Labels:
    None
  • Testing Instructions:
    Hide
    1. Create a lesson in moodle.
    2. Change the interface language to Arabic.
    3. An horizontal scroll bar shouldn't appears inside the lesson

    note: adding language to the site:

    1. site admin > language > language packs
    2. select language to install
    3. setting to display language selection on home page: site admin > language > language settings > enable display language menu
    Show
    Create a lesson in moodle. Change the interface language to Arabic. An horizontal scroll bar shouldn't appears inside the lesson note: adding language to the site: site admin > language > language packs select language to install setting to display language selection on home page: site admin > language > language settings > enable display language menu
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

For an unknown reason, using with Arabic languages the lesson is unnecessarily wider than the browser window, although there is nothing beyond the left border (left since its rtl) of the document).
And this problem appears with the standard moodle theme also.
I tried to disable the css but with not result.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Marwan Chaaya added a comment -

It seems it is related to the left side menu of the lesson. If I choose NOT to show the left menu, the scrollbar disappear!!

Show
Marwan Chaaya added a comment - It seems it is related to the left side menu of the lesson. If I choose NOT to show the left menu, the scrollbar disappear!!
Hide
Permalink
Rossiani Wijaya added a comment -

Fixed .skip CSS class in lesson to be similar to .skip class in core.css

Posting patch.

Show
Rossiani Wijaya added a comment - Fixed .skip CSS class in lesson to be similar to .skip class in core.css Posting patch.
Hide
Permalink
Adrian Greeve added a comment -

The fix looks good.
My only suggestion is possibly to update the test instructions to include how to switch to Arabic (for dumb people like me).
Thanks Rossie.

Show
Adrian Greeve added a comment - The fix looks good. My only suggestion is possibly to update the test instructions to include how to switch to Arabic (for dumb people like me). Thanks Rossie.
Hide
Permalink
Rossiani Wijaya added a comment -

Thanks Adrian for reviewing.

Update testing instruction.

Submitting this for integration review.

Show
Rossiani Wijaya added a comment - Thanks Adrian for reviewing. Update testing instruction. Submitting this for integration review.
Hide
Permalink
Marwan Chaaya added a comment -

Hey Rossiani, Can you explain in details how to get the fix and how to use it. I can't find .skip in lesson, and I can't see a .skip in core.css also.

Thank you for your effort

Show
Marwan Chaaya added a comment - Hey Rossiani, Can you explain in details how to get the fix and how to use it. I can't find .skip in lesson, and I can't see a .skip in core.css also. Thank you for your effort
Hide
Permalink
Rossiani Wijaya added a comment -

Hi Marwan,

The css file is located at mod/lesson/styles.css. Find the following line:

.path-mod-lesson .skip {position: absolute;left: -1000em;width: 20em;}

change it to

.path-mod-lesson .skip {position: absolute;top: -1000em;width: 20em;}

As admin, 'Purge all caches' and it should fix the issue.

Show
Rossiani Wijaya added a comment - Hi Marwan, The css file is located at mod/lesson/styles.css. Find the following line: .path-mod-lesson .skip {position: absolute;left: -1000em;width: 20em;} change it to .path-mod-lesson .skip {position: absolute;top: -1000em;width: 20em;} As admin, 'Purge all caches' and it should fix the issue.
Hide
Permalink
Marwan Chaaya added a comment -

I tried it, it is NOT working . I still have the same problem.
Note, in addition to the testing instructions, the lesson should : Display left menu

Thank you

Show
Marwan Chaaya added a comment - I tried it, it is NOT working . I still have the same problem. Note, in addition to the testing instructions, the lesson should : Display left menu Thank you
Hide
Permalink
Rossiani Wijaya added a comment -

Did you purge all caches (site admin > development > purge all caches)?

Show
Rossiani Wijaya added a comment - Did you purge all caches (site admin > development > purge all caches)?
Hide
Permalink
Marwan Chaaya added a comment -

Hey Rossiani,
I forgot to purge all caches, my bad It is working perfectly.
Thank you very much

Show
Marwan Chaaya added a comment - Hey Rossiani, I forgot to purge all caches, my bad It is working perfectly. Thank you very much
Hide
Permalink
Aparup Banerjee added a comment -

Thanks for the work , thats been integrated. This probably needs testing in some versions.

Marwan: on which versions did you test the patch on?

Show
Aparup Banerjee added a comment - Thanks for the work , thats been integrated. This probably needs testing in some versions. Marwan: on which versions did you test the patch on?
Hide
Permalink
Marwan Chaaya added a comment -

I updated to version 2.2.1
I don't know about previous versions.

Show
Marwan Chaaya added a comment - I updated to version 2.2.1 I don't know about previous versions.
Hide
Permalink
Andrew Davis added a comment -

Should I be getting a horizontal scrollbar? According to the testing instructions I should but Im not. It seems that the testing instructions are probably wrong.

Show
Andrew Davis added a comment - Should I be getting a horizontal scrollbar? According to the testing instructions I should but Im not. It seems that the testing instructions are probably wrong.
Hide
Permalink
Rossiani Wijaya added a comment -

Hi Andrew,

You are right. It's a mistake on the testing instruction. The horizontal scrollbar shouldn't appear on the page.

I updated the testing instruction.

Thank you for testing it.

Show
Rossiani Wijaya added a comment - Hi Andrew, You are right. It's a mistake on the testing instruction. The horizontal scrollbar shouldn't appear on the page. I updated the testing instruction. Thank you for testing it.
Hide
Permalink
Andrew Davis added a comment -

It now works as described. Passing.

Show
Andrew Davis added a comment - It now works as described. Passing.
Hide
Permalink
Marwan Chaaya added a comment -

Hey Andrew and Rossiani, you should add the following to the testing instructions:
Testing Instructions:
1-Create a lesson in moodle.
2-Change the interface language to Arabic.
3-An horizontal scroll bar shouldn't appears inside the lesson
4- THE LESSON SHOULD HAVE A MENU ENABLED FROM THE SETTINGS.
Note: Version 1.9 is also affected.

Show
Marwan Chaaya added a comment - Hey Andrew and Rossiani, you should add the following to the testing instructions: Testing Instructions: 1-Create a lesson in moodle. 2-Change the interface language to Arabic. 3-An horizontal scroll bar shouldn't appears inside the lesson 4- THE LESSON SHOULD HAVE A MENU ENABLED FROM THE SETTINGS. Note: Version 1.9 is also affected.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Well,

I wish I said it every time
you do the things you do.
You always lend a helping hand,
and I'm filled with gratitude.

You are strong and generous
for each and everyone one of us.
I am eternally grateful,
I cannot say thanks enough.

Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: