reassigning to messaging maintainer, thanks for the report and patch

Attaching another patch that resolves a missing string for the message output. This should be applied with the first patch; it is not a replacement.

I'm curious, who is Eugene Venter? He's listed as the original author in messages.php in your patch.

Looks like the get_string() fixes have already been made in master at least.

I've added a git branch and diff URL containing the changes. The only problem we have now is that "PayPal enrolment messages" now appears in the messaging settings for everyone even if the Paypal enrolment plugin is disabled.

Hi Andrew. I don't know who Eugene Venter is. His name shows up throughout the paypal plugin.

As you're the original author of that messages.php file the @copyright should really be you. Do you mind if I put your name in? It would then look like this...

@copyright 2012 Chris Follin

Putting this up for peer review. I've added db/messages.php for some of the other enrolment plugins. Chris, for the moment I've got your name in the messages.php you created. Let me know if you want it taken out for whatever reason.

Yes, that's fine. I had copied the whole header from another paypal file to be sure I included everything but didn't change the name. Thanks, Andrew.

Looks good Andrew.

Do you need a @category doc-tag for the files or not? I can't remember what the decision was during the doc sprint...

And line 402 of lib/messagelib.php is added whitespace - was this intentional?

As I understand the function of the category tag its used to mark areas that might be of interest to external developers. I could be wrong though...

The white space at line 402 was deliberate so that it is formatted all purty.

Dear integrators. I have created versions for master and 2.2 stable. Are you able to cherry-pick into 2.1 stable? I attempted to do so, got conflicts due to all the altered version.php files, somehow messed up resolving the conflicts and now the commit isn't in my log and git won't let me cherry-pick it again as it says it is "bad object".

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Thanks Andrew, this has been integrated now.
It looks like Authorize plugin may be missing a string, but with a quick look I couldn't find the plugin settings anywhere. I suppose testing will turn that up if it is in fact missing.

Cheers
Sam

I wasn't able to complete the test.

I tried this with a real PayPal account and a Sandbox one. I kept receiving an error after successfully paying and returning back to Moodle. In the sandbox instructions (looking rather dated) there was some alternate code, but that didn't change the outcome.

So I wasn't able to get to the point where the message would be sent.

I've tried to seek help from others with PayPal experience, but I couldn't find any volunteers.

Hi, Chris.

As reporter, I assume you have a working PayPal setup. Can you test this?

Michael,
We applied the patch to our production systems in February. It's confirmed as working.

Spoke to Andrew and he is happy with this test being sufficient.

UPDATE tracker_issues
   SET status = 'Closed',
      comment = 'Thanks!'
WHEN participants = 'Did a gorgeous work'

This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).