[MDL-31429] PayPal Enrolment Message Provider Not Installed - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.1.3
Fix Version/s: 2.1.6, 2.2.3
Component/s: Enrolments
Labels:
- partner
- patch
- triaged

Database:

Any
Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Master Branch:
~~MDL-31429~~_paypal_messages
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-31429_paypal_messages
Workaround:

Hide

Turn off the notifications in PayPal enrollment plugin settings, but this does not prevent errors when a PayPal enrollment fails for some other reason and message_send() is called to send a notification of the error to the admin.

Show
Turn off the notifications in PayPal enrollment plugin settings, but this does not prevent errors when a PayPal enrollment fails for some other reason and message_send() is called to send a notification of the error to the admin.
Testing Instructions:

Hide

As admin go to site admin > plugins > enrolments > manage enrol plugins
Enable ims enterprise, flat file and paypal.
Go to my profile settings > messaging and check that ims enterprise, flat file and paypal enrolment messages appear.
Disable the 3 enrolment plugins.
Refresh your messaging settings and check that the 3 enrolment messages no longer appear.

Re-enable paypal.

Go into the paypal enrolment options.
Enable the notifications to students, teachers, and/or admins on the PayPal enrolment settings page.
Set Allow PayPal enrolments to yes.
Enrol into a course via PayPal.
You should receive the notifications and the message and body strings should have been found.

Show
As admin go to site admin > plugins > enrolments > manage enrol plugins Enable ims enterprise, flat file and paypal. Go to my profile settings > messaging and check that ims enterprise, flat file and paypal enrolment messages appear. Disable the 3 enrolment plugins. Refresh your messaging settings and check that the 3 enrolment messages no longer appear. Re-enable paypal. Go into the paypal enrolment options. Enable the notifications to students, teachers, and/or admins on the PayPal enrolment settings page. Set Allow PayPal enrolments to yes. Enrol into a course via PayPal. You should receive the notifications and the message and body strings should have been found.

Description

The PayPal enrollment plugin uses message_send() to send notifications of failures to admins and of successes to students, teachers, and admins; however, the message provider was not installed in the 2.0 upgrade so all of these messages are failing. enrol/paypal/db/messages.php does not exist.

I'm attaching a patch that creates enrol/paypal/db/messages.php, bumps the version of enrol/paypal by 1 so that the message provider can be installed, and also fixes a few get_string() calls that were not looking for the strings in the correct component, which should be enrol.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-31429.patch
4 kB
31/Jan/12 5:05 PM
MDL-31429_languagestring.patch
1.0 kB
10/Apr/12 8:54 AM

Issue Links

has a non-specific relationship to

MDL-30647 PayPal Setup Needs notify_url variable

Closed

is duplicated by

MDL-32922 paypal plugin send notice doesn't work

Closed

Activity

People

Assignee:: Andrew Davis

Reporter:: Chris Follin

Peer reviewer:: Jason Fowler

Integrator:: Sam Hemelryk

Participants:: Andrew Davis, Chris Follin, Dan Poltawski, Eloy Lafuente (stronk7), Jason Fowler, Michael de Raadt, Petr Skoda, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)

Votes:: 2 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 31/Jan/12 5:03 PM

Updated:: 28/Jul/18 1:15 AM

Resolved:: 06/May/12 1:41 AM

Fix Release Date:: 14/May/12