Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31443

The message of the dialogue displayed when backup, restore or import is not consistent

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3.4, 2.4.1, 2.5, 3.3.6, 3.4.3, 3.5
    • Fix Version/s: 3.4.4, 3.5.1
    • Component/s: Backup
    • Testing Instructions:
      Hide
      Test 1
      1. Log in as an admin.
      2. Create a course.
      3. Visit the course.
      4. Click on ‘Import’.
      5. Select a course and press ‘Continue’.
      6. Confirm the heading says ‘Import settings’.
      7. Click ‘Next’.
      8. Click ‘Next’.
      9. Confirm the heading says ‘Import settings’.
      10. Click ‘Cancel’.
      11. Confirm the heading in the display message says ‘Cancel import’.
      Test 2
      1. Log in as an admin.
      2. Create a course.
      3. Visit the course.
      4. Click on ‘Backup’.
      5. Confirm the heading says ‘Backup settings’.
      6. Click ‘Next’.
      7. Click ‘Next’.
      8. Confirm the heading says ‘Backup settings’.
      9. Click ‘Cancel’.
      10. Confirm the heading in the display message says ‘Cancel backup’.
      Test 3
      1. Log in as an admin.
      2. Create a course.
      3. Backup the course.
      4. Click on ‘Restore’ next to the backup archive name.
      5. Click ‘Continue’.
      6. Choose to restore as a new course and click ‘Continue’.
      7. Confirm the heading says ‘Restore settings’.
      8. Click ‘Next’.
      9. Click on the cancel button.
      10. Confirm the heading in the display message says ‘Cancel restore’.
      11. Click 'Stay'.
      12. Click 'Next'.
      13. Confirm the heading says ‘Restore settings’.
      14. Click ‘Cancel’.
      15. Confirm the heading in the display message says ‘Cancel restore’.
      Show
      Test 1 Log in as an admin. Create a course. Visit the course. Click on ‘Import’. Select a course and press ‘Continue’. Confirm the heading says ‘Import settings’. Click ‘Next’. Click ‘Next’. Confirm the heading says ‘Import settings’. Click ‘Cancel’. Confirm the heading in the display message says ‘Cancel import’. Test 2 Log in as an admin. Create a course. Visit the course. Click on ‘Backup’. Confirm the heading says ‘Backup settings’. Click ‘Next’. Click ‘Next’. Confirm the heading says ‘Backup settings’. Click ‘Cancel’. Confirm the heading in the display message says ‘Cancel backup’. Test 3 Log in as an admin. Create a course. Backup the course. Click on ‘Restore’ next to the backup archive name. Click ‘Continue’. Choose to restore as a new course and click ‘Continue’. Confirm the heading says ‘Restore settings’. Click ‘Next’. Click on the cancel button. Confirm the heading in the display message says ‘Cancel restore’. Click 'Stay'. Click 'Next'. Confirm the heading says ‘Restore settings’. Click ‘Cancel’. Confirm the heading in the display message says ‘Cancel restore’.
    • Workaround:
      Hide

      Understand that we do not talk about backup but import or restoration

      Show
      Understand that we do not talk about backup but import or restoration
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31443-master
    • Pull Master Diff URL:

      Description

      Currently, the message in the dialog displayed when a button "cancel" is clicked in all stages is always the one for backup. The message should be specific to the three cases:

      • backup
      • import
      • restore

        Attachments

        1. exemple.jpg
          exemple.jpg
          45 kB
        2. MDL-31443_test 3.PNG
          MDL-31443_test 3.PNG
          39 kB
        3. MDL-31443.png
          MDL-31443.png
          45 kB
        4. MDL-31443.xlsx
          7.78 MB
        5. MDL-31443-title.png
          MDL-31443-title.png
          115 kB
        6. patch(MDL-31443) - backup .txt
          0.1 kB
        7. patch01 (MDL-31443).diff
          1 kB
        8. patch01 (MDL-31443) updated.diff
          1 kB
        9. patch02 (MDL-31443).diff
          1 kB

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33440 Cancel backup confirm buttons are confusing

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-31403 Add a dialogue message warning that the importation, backup and restore process of a course can be long and prevent clicking twice on the import

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              leblangi Gilles-Philippe Leblanc
              Peer reviewer:
              Mark Nelson Mark Nelson
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h