Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31445

moodleforms unique id on field div wrappers

    XMLWordPrintable

Details

    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • Hide

      note to tester: you could test the related MDL-31469 at the same time

      For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
      a. add forum,
      b. create multichoice question,
      c. ...)

      1. Go to the form, and make sure it looks/works OK>
      2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
      3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)

      Show
      note to tester: you could test the related MDL-31469 at the same time For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like a. add forum, b. create multichoice question, c. ...) 1. Go to the form, and make sure it looks/works OK> 2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field. 3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469 .)

    Description

      It would be useful, when authoring CSS, if MoodleForms gave a unique id to the top level div wrapping each label and field.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31469 optional formslib date selector element generates invaild HTML

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33685 Formslib creating multiple divs with same id.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-10505 Add group name to rendered elements for better CSS control

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-30204 formslib should add more class names to the HTML to make styling easier

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              anthonyforth Anthony Forth
              anthonyforth Anthony Forth
              Tim Hunt Tim Hunt
              Aparup Banerjee Aparup Banerjee
              Adrian Greeve Adrian Greeve
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Mar/12