Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31445

moodleforms unique id on field div wrappers

    Details

    • Testing Instructions:
      Hide

      note to tester: you could test the related MDL-31469 at the same time

      For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
      a. add forum,
      b. create multichoice question,
      c. ...)

      1. Go to the form, and make sure it looks/works OK>
      2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
      3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)

      Show
      note to tester: you could test the related MDL-31469 at the same time For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like a. add forum, b. create multichoice question, c. ...) 1. Go to the form, and make sure it looks/works OK> 2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field. 3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469 .)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      It would be useful, when authoring CSS, if MoodleForms gave a unique id to the top level div wrapping each label and field.

        Gliffy Diagrams

          Issue Links

            Activity

            anthonyforth Anthony Forth created issue -
            anthonyforth Anthony Forth made changes -
            Field Original Value New Value
            Assignee moodle.com [ moodle.com ] Anthony Forth [ anthonyforth ]
            anthonyforth Anthony Forth made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Pull Master Diff URL https://github.com/anthonyforth/moodle/compare/master...MDL-31445
            Pull Master Branch MDL-31445
            Pull from Repository git@github.com:anthonyforth/moodle.git
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            Component/s Themes [ 10088 ]
            salvetore Michael de Raadt made changes -
            Labels triaged patch triaged
            timhunt Tim Hunt made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer timhunt
            timhunt Tim Hunt made changes -
            Link This issue is duplicated by MDL-10505 [ MDL-10505 ]
            timhunt Tim Hunt made changes -
            Link This issue is duplicated by MDL-30204 [ MDL-30204 ]
            timhunt Tim Hunt made changes -
            Link This issue testing discovered MDL-31469 [ MDL-31469 ]
            timhunt Tim Hunt made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            timhunt Tim Hunt made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/anthonyforth/moodle/compare/master...MDL-31445 https://github.com/timhunt/moodle/compare/master...MDL-31445
            Pull from Repository git@github.com:anthonyforth/moodle.git git://github.com/timhunt/moodle.git
            Testing Instructions For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
            a. add forum,
            b. create multichoice question,
            c. ...)

            1. Go to the form, and make sure it looks/works OK>
            2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
            3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)
            Pull 2.1 Branch MDL-31445_21
            Pull 2.2 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_22_STABLE...MDL-31445_22
            Pull 2.1 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-31445_21
            Pull 2.2 Branch MDL-31445_22
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            nebgor Aparup Banerjee made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator nebgor
            nebgor Aparup Banerjee made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.1.4 [ 11452 ]
            Affects Version/s 2.3 [ 10657 ]
            Fix Version/s 2.1.5 [ 11553 ]
            Fix Version/s 2.2.2 [ 11552 ]
            Fix Version/s STABLE backlog [ 10463 ]
            nebgor Aparup Banerjee made changes -
            Testing Instructions For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
            a. add forum,
            b. create multichoice question,
            c. ...)

            1. Go to the form, and make sure it looks/works OK>
            2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
            3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)
            note to tester: you could test the related MDL-31445 at the same time

            For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
            a. add forum,
            b. create multichoice question,
            c. ...)

            1. Go to the form, and make sure it looks/works OK>
            2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
            3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)
            nebgor Aparup Banerjee made changes -
            Testing Instructions note to tester: you could test the related MDL-31445 at the same time

            For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
            a. add forum,
            b. create multichoice question,
            c. ...)

            1. Go to the form, and make sure it looks/works OK>
            2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
            3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)
            note to tester: you could test the related MDL-31469 at the same time

            For a variety of forms in Moodle (I tested on the quiz settings form, so I would suggest you test on some other complex forms like
            a. add forum,
            b. create multichoice question,
            c. ...)

            1. Go to the form, and make sure it looks/works OK>
            2. Use a tool like firebug to instpect the HTML, and marvel at the beauty of the new id and class attributes on the outer wrapper div for each form field.
            3. Validate the HTML of the page, and make sure there are no problems relating to the ids. (Note that there are other problems, which may include MDL-31469.)
            abgreeve Adrian Greeve made changes -
            Tester abgreeve
            abgreeve Adrian Greeve made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            abgreeve Adrian Greeve made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 13/Feb/12
            salvetore Michael de Raadt made changes -
            Link This issue has been marked as being related by MDL-33685 [ MDL-33685 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12