Moodle
  1. Moodle
  2. MDL-31461

Plagiarism functions print_disclosure update_status should allow use with renderers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.3
    • Fix Version/s: 2.2.2
    • Component/s: Plagiarism
    • Labels:
    • Testing Instructions:
      Hide

      No Testing required/possible - this is for an API which doesn't have any core plugins so no core code actually uses these hooks.

      • This is backwards compatible with older plugins so won't break anything either - it just allows us to set the plagiarism functions up to work inside renderers in a much better way.

      Tester: please do some general plagiarism usage to check/learn how it works

      Show
      No Testing required/possible - this is for an API which doesn't have any core plugins so no core code actually uses these hooks. This is backwards compatible with older plugins so won't break anything either - it just allows us to set the plagiarism functions up to work inside renderers in a much better way. Tester: please do some general plagiarism usage to check/learn how it works
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-31461
    • Rank:
      37990

      Description

      We need to change the way these functions are called - and echo the return value of the function instead of relying on the function to print the stuff itself - this will allow us to use these better in renderer functions.

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          NOTE TO INTEGRATOR - Master and 22Stable only please - don't need 21stable.

          thanks!

          Show
          Dan Marsden added a comment - NOTE TO INTEGRATOR - Master and 22Stable only please - don't need 21stable. thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Marsden added a comment -

          rebased.

          Show
          Dan Marsden added a comment - rebased.
          Hide
          Aparup Banerjee added a comment -

          Hi Dan,
          this looks fine to me overall. I understand from MdR that you're working on the phpdoc for plagiarism too.
          note: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.return.pkg.html - we need a description for the '@return string ...'
          cheers,
          Aparup

          Show
          Aparup Banerjee added a comment - Hi Dan, this looks fine to me overall. I understand from MdR that you're working on the phpdoc for plagiarism too. note: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.return.pkg.html - we need a description for the '@return string ...' cheers, Aparup
          Hide
          Dan Marsden added a comment -

          yep - was hoping to do some of that this week - will handle PHPdoc/docs.moodle.org stuff on a separate tracker issue - thanks for the reminder.

          Show
          Dan Marsden added a comment - yep - was hoping to do some of that this week - will handle PHPdoc/docs.moodle.org stuff on a separate tracker issue - thanks for the reminder.
          Hide
          Aparup Banerjee added a comment -

          Thanks Dan,
          thats integrated into 22 and master

          Show
          Aparup Banerjee added a comment - Thanks Dan, thats integrated into 22 and master
          Hide
          Rajesh Taneja added a comment -

          Works Good.
          Thanks for fixing this Dan and pointing me in right direction.

          Show
          Rajesh Taneja added a comment - Works Good. Thanks for fixing this Dan and pointing me in right direction.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          A bit later this week, but finally your changes have been accepted and are now available in all the upstream git/cvs servers.

          Many thanks & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - A bit later this week, but finally your changes have been accepted and are now available in all the upstream git/cvs servers. Many thanks & ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: