Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31469

optional formslib date selector element generates invaild HTML

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.7, 2.1.4, 2.2.1, 2.3
          • Fix Version/s: 2.1.5, 2.2.2
          • Component/s: Forms Library
          • Labels:
          • Testing Instructions:
            Hide

            note to tester: you could test the related MDL-31469 at the same time

            1. Go to any from that includes optional dates, for example the quiz settings form.
            2. Validate the HTML, and verify that there are no errors about <label for="">.

            Show
            note to tester: you could test the related MDL-31469 at the same time 1. Go to any from that includes optional dates, for example the quiz settings form. 2. Validate the HTML, and verify that there are no errors about <label for="">.
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Pull from Repository:
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            The [] Enabled checkbox is output including <label for="">. We need a correct id there.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  Testing discovered

                  Improvement - An enhancement to an existing Moodle feature. MDL-31445 moodleforms unique id on field div wrappers

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    timhunt Tim Hunt added a comment -

                    Submitting for integration.

                    Show
                    timhunt Tim Hunt added a comment - Submitting for integration.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                    TIA and ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                    Hide
                    Permalink
                    nebgor Aparup Banerjee added a comment -

                    Thanks Tim, thats been integrated now into 21, 22 and master.

                    tester: you could test the related MDL-31445 at the same time.

                    Show
                    nebgor Aparup Banerjee added a comment - Thanks Tim, thats been integrated now into 21, 22 and master. tester: you could test the related MDL-31445 at the same time.
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    I checked this in version 2.1, 2.2 and master. I also tested this in different forms (quiz, forum, data). Everything checked out fine.
                    I also ran an HTML validation tool on the pages. Nothing came up that related to this fix.
                    Thanks Tim.

                    Show
                    abgreeve Adrian Greeve added a comment - I checked this in version 2.1, 2.2 and master. I also tested this in different forms (quiz, forum, data). Everything checked out fine. I also ran an HTML validation tool on the pages. Nothing came up that related to this fix. Thanks Tim.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    A bit later this week, but finally your changes have been accepted and are now available in all the upstream git/cvs servers.

                    Many thanks & ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - A bit later this week, but finally your changes have been accepted and are now available in all the upstream git/cvs servers. Many thanks & ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        1 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          12/Mar/12