Moodle

optional formslib date selector element generates invaild HTML

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.7, 2.1.4, 2.2.1, 2.3
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: Forms Library
  • Labels:
  • Testing Instructions:
    Hide

    note to tester: you could test the related MDL-31469 at the same time

    1. Go to any from that includes optional dates, for example the quiz settings form.
    2. Validate the HTML, and verify that there are no errors about <label for="">.

    Show
    note to tester: you could test the related MDL-31469 at the same time 1. Go to any from that includes optional dates, for example the quiz settings form. 2. Validate the HTML, and verify that there are no errors about <label for="">.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

The [] Enabled checkbox is output including <label for="">. We need a correct id there.

Issue Links

discovered while testing

Improvement - An enhancement to an existing Moodle feature. MDL-31445 moodleforms unique id on field div wrappers

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Submitting for integration.

Show
Tim Hunt added a comment - Submitting for integration.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Aparup Banerjee added a comment -

Thanks Tim, thats been integrated now into 21, 22 and master.

tester: you could test the related MDL-31445 at the same time.

Show
Aparup Banerjee added a comment - Thanks Tim, thats been integrated now into 21, 22 and master. tester: you could test the related MDL-31445 at the same time.
Hide
Permalink
Adrian Greeve added a comment -

I checked this in version 2.1, 2.2 and master. I also tested this in different forms (quiz, forum, data). Everything checked out fine.
I also ran an HTML validation tool on the pages. Nothing came up that related to this fix.
Thanks Tim.

Show
Adrian Greeve added a comment - I checked this in version 2.1, 2.2 and master. I also tested this in different forms (quiz, forum, data). Everything checked out fine. I also ran an HTML validation tool on the pages. Nothing came up that related to this fix. Thanks Tim.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

A bit later this week, but finally your changes have been accepted and are now available in all the upstream git/cvs servers.

Many thanks & ciao

Show
Eloy Lafuente (stronk7) added a comment - A bit later this week, but finally your changes have been accepted and are now available in all the upstream git/cvs servers. Many thanks & ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: