Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31487

Ensure grade items remain hidden if explicitly hidden via gradebook (regardless of activity state)

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.2, 2.1, 2.2, 2.4.5, 2.5.1
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Gradebook, Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. In a new test course, create a graded activity like a mod_assign, where visibility of the grade item is controlled by the gradebook.
      2. Create a quiz where the reviwe options say that marks are visible all the time. (This should be the default.)
      3. In the gradebook, go to the Categries and items simple view.
      4. In another tab, open your User grades report.
      5. Verify that both grade items are there, as is the course total item, and the category for all the grades in the course.
      6. Verify that, on the categories and items page, all the grade items, except the quiz, have an 'eye-con', and that they work to show or hide the item.
      7. Click the 'eye-con' for the grade category. Verify that all the grades items are hidden except the quiz.
      8. Then click the eyecon again to make them all visible.
      9. On the course page, click the eyecon to hide both the quiz and the assignment.
      10. Verify that both grade items are now hidden in the grade book.
      11. Repeat the last two steps, but by using the Edit settings form for each activity, rather than the eyecon on the course page.
      12. If you get through all that, have a well-earned coffee/beer/mohito.
      Show
      In a new test course, create a graded activity like a mod_assign, where visibility of the grade item is controlled by the gradebook. Create a quiz where the reviwe options say that marks are visible all the time. (This should be the default.) In the gradebook, go to the Categries and items simple view. In another tab, open your User grades report. Verify that both grade items are there, as is the course total item, and the category for all the grades in the course. Verify that, on the categories and items page, all the grade items, except the quiz, have an 'eye-con', and that they work to show or hide the item. Click the 'eye-con' for the grade category. Verify that all the grades items are hidden except the quiz. Then click the eyecon again to make them all visible. On the course page, click the eyecon to hide both the quiz and the assignment. Verify that both grade items are now hidden in the grade book. Repeat the last two steps, but by using the Edit settings form for each activity, rather than the eyecon on the course page. If you get through all that, have a well-earned coffee/beer/mohito.
    • Workaround:
      Hide

      Remember to Show/Hide each grade item within the gradebook whenever the state changes on the main course page.

      Show
      Remember to Show/Hide each grade item within the gradebook whenever the state changes on the main course page.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Add additional data to grade item for the purposes of show/hide checking.

      It should be possible for a grade item to remain hidden if explicitly hidden (via the show/hide icon or the "hidden until" setting) regardless of the activity's state in the course.

      As per discussion http://moodle.org/mod/forum/discuss.php?d=195014

      Action Course Page Gradebook Notes
      Create a quiz + show it to students Quiz activity displayed Quiz grade item is displayed This is good!
      Hide the quiz on the main course page Quiz activity hidden Quiz grade item is hidden this is good!
      Show the quiz again Quiz activity displayed Quiz grade item is displayed good again!
      Hide the quiz grade item in the gradebook (without altering the quiz activity) Quiz activity still displayed Quiz grade item is hidden good...
      Hide the quiz activity on the main course page (without altering the quiz grade item) Quiz is hidden Quiz grade item is still hidden this is good too!
      Show the quiz activity on the main course page (without altering the quiz grade item) Quiz activity now displayed Quiz grade item now displayed NOT GOOD! I expect the grade item to remain hidden as set within the gradebook

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/13