Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31501

New session infrastructure - file, database and memcached storage

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.5
    • Fix Version/s: 2.6
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Repeat following for all 3 session handlers (database, file, memcached), see config-dit.php for configuration options.

      1. run phpunit tests
      2. install moodle
      3. upgrade moodle from 2.2 and 2.5
      4. login - logout - login - logout
      5. login in multiple browsers with multiple accounts - verify the sessions table gets filled with all sessions and the timemodified column is updated every 20 seconds
      6. login in one browser and delete or suspend the account as admin from different browser - user should be kicked out
      7. verify session locking works (please note the first http requests is not locked) - the easiest way is to create a script with require('config.php') followed by sleep(30);

      Other tests:

      1. verify that file based handler is used by default in new installs
      2. verify the "database sessions option" disappears if you put $CFG->session_handler_class into your config.php
      3. be creative and try to come up with more session related testing
      Show
      Repeat following for all 3 session handlers (database, file, memcached), see config-dit.php for configuration options. run phpunit tests install moodle upgrade moodle from 2.2 and 2.5 login - logout - login - logout login in multiple browsers with multiple accounts - verify the sessions table gets filled with all sessions and the timemodified column is updated every 20 seconds login in one browser and delete or suspend the account as admin from different browser - user should be kicked out verify session locking works (please note the first http requests is not locked) - the easiest way is to create a script with require('config.php') followed by sleep(30); Other tests: verify that file based handler is used by default in new installs verify the "database sessions option" disappears if you put $CFG->session_handler_class into your config.php be creative and try to come up with more session related testing
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      w39_MDL-31501_m26_sessionreboot
    • Pull Master Diff URL:
    • Documentation link:
    • Story Points:
      100
    • Sprint:
      BACKEND Sprint 4

      Description

      The OU finds memcache for session handling to be important for performance. Here is our code to be commented on, and hopefully, if good enough, added to core.

      Edit: This ticket has been highjacked for memcached session handler instead of memcache.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42485 Memcached sessions lose lock early

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51365 Session TTL set arbitrarily high

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41998 Upgraded a site from 2.2. Now getting a JS error that makes navigation block unusable

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42860 improve (configdbsessions, admin) string to match new session code

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46552 memcached session driver does not support multiple servers

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-42011 session improvements

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41787 MATURITY_ALPHA and friends cannot be defined in lib/setuplib.php

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Sam Hemelryk
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              20 Vote for this issue
              Watchers:
              33 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13