Moodle
  1. Moodle
  2. MDL-31513

Confusingly named button on external services page

    Details

      Description

      When editing the external services settings the button at the bottom is labeled "Edit Service" rather than "Save changes". This is confusing, and inconsistent with the rest of Moodle.

        Gliffy Diagrams

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting that.

          Show
          Michael de Raadt added a comment - Thanks for reporting that.
          Hide
          Iurii Kucherov added a comment -

          Please have a look at it.
          I renamed "Edit service" to "Save changes"

          https://github.com/yuyokk/moodle/compare/master...MDL-31513-master

          Show
          Iurii Kucherov added a comment - Please have a look at it. I renamed "Edit service" to "Save changes" https://github.com/yuyokk/moodle/compare/master...MDL-31513-master
          Hide
          Jérôme Mouneyrac added a comment -

          Thanks Iurii, I send it to integration.

          Show
          Jérôme Mouneyrac added a comment - Thanks Iurii, I send it to integration.
          Hide
          Jérôme Mouneyrac added a comment - - edited

          PS for integrators: I didn't port it to 2.2 and 2.1, I guess you can easily cherry-pick when it is an one line commit. From what I understood it doesn't change your work load to cherry-pick a not conflicting commit. But if ever it is time consuming, let me know and I will create branch for 2.2 and 2.1.

          Show
          Jérôme Mouneyrac added a comment - - edited PS for integrators: I didn't port it to 2.2 and 2.1, I guess you can easily cherry-pick when it is an one line commit. From what I understood it doesn't change your work load to cherry-pick a not conflicting commit. But if ever it is time consuming, let me know and I will create branch for 2.2 and 2.1.
          Hide
          Sam Hemelryk added a comment -

          Thanks everyone.

          No problems cherry-picking a single line commit providing its not causing conflicts

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks everyone. No problems cherry-picking a single line commit providing its not causing conflicts Cheers Sam
          Hide
          Ankit Agarwal added a comment -

          All good.
          Testing passed
          Thanks

          Show
          Ankit Agarwal added a comment - All good. Testing passed Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has landed upstream, finally! Yay!

          תודה רבה && شكرا جزيلا



          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: