Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31513

Confusingly named button on external services page

    Details

      Description

      When editing the external services settings the button at the bottom is labeled "Edit Service" rather than "Save changes". This is confusing, and inconsistent with the rest of Moodle.

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting that.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting that.
          Hide
          yuyokk Iurii Kucherov added a comment -

          Please have a look at it.
          I renamed "Edit service" to "Save changes"

          https://github.com/yuyokk/moodle/compare/master...MDL-31513-master

          Show
          yuyokk Iurii Kucherov added a comment - Please have a look at it. I renamed "Edit service" to "Save changes" https://github.com/yuyokk/moodle/compare/master...MDL-31513-master
          Hide
          jerome Jérôme Mouneyrac added a comment -

          Thanks Iurii, I send it to integration.

          Show
          jerome Jérôme Mouneyrac added a comment - Thanks Iurii, I send it to integration.
          Hide
          jerome Jérôme Mouneyrac added a comment - - edited

          PS for integrators: I didn't port it to 2.2 and 2.1, I guess you can easily cherry-pick when it is an one line commit. From what I understood it doesn't change your work load to cherry-pick a not conflicting commit. But if ever it is time consuming, let me know and I will create branch for 2.2 and 2.1.

          Show
          jerome Jérôme Mouneyrac added a comment - - edited PS for integrators: I didn't port it to 2.2 and 2.1, I guess you can easily cherry-pick when it is an one line commit. From what I understood it doesn't change your work load to cherry-pick a not conflicting commit. But if ever it is time consuming, let me know and I will create branch for 2.2 and 2.1.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks everyone.

          No problems cherry-picking a single line commit providing its not causing conflicts

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks everyone. No problems cherry-picking a single line commit providing its not causing conflicts Cheers Sam
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          All good.
          Testing passed
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - All good. Testing passed Thanks
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          And this has landed upstream, finally! Yay!

          תודה רבה && شكرا جزيلا



          Closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12