Moodle
  1. Moodle
  2. MDL-31516

Problem with comma decimal separator in grade "Categories and items"

    Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1- Go in a course which have activities and students.
      2- Click on Grades in the Course administration
      3- Click on the Categories and items panel
      4- Choose "Weighted mean og grades" in the aggregation list
      5- Switch to Français (fr) language.

      You should see the problem with numbers in the "Weight" column

      Show
      1- Go in a course which have activities and students. 2- Click on Grades in the Course administration 3- Click on the Categories and items panel 4- Choose "Weighted mean og grades" in the aggregation list 5- Switch to Français (fr) language. You should see the problem with numbers in the "Weight" column
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
      git@github.com:StudiUM/moodle.git
    • Pull Master Branch:
      MDL-31516_grade_comma_decsep
    • Rank:
      38066

      Description

      Integer values are not displayed correctly in Grade "Categories and items" views when decimal separator is a comma (french language).

      For example :
      English French
      1.0 -> 1,
      0.0 -> 0,

      This bug as been found fixing Unit tests when language is set to french -> http://tracker.moodle.org/browse/MDL-30307

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for spotting that and providing a fix.

          Show
          Michael de Raadt added a comment - Thanks for spotting that and providing a fix.
          Hide
          Frédéric Massart added a comment - - edited

          Sprint planning.
          Estimated development difficulty: S M

          Show
          Frédéric Massart added a comment - - edited Sprint planning. Estimated development difficulty: S M
          Hide
          Frédéric Massart added a comment -

          Hi Jean-Philippe. I reviewed your patch and it looks good to me. In order to simplify integrator's life, could you rebase your patch onto the current stables? The only branches we need are 2.2, 2.3 and master. Oh, and if you could rephrase your commit message for it to start with 'MDL-31516 Gradebook: ' that'd be awesome. Thanks!

          Show
          Frédéric Massart added a comment - Hi Jean-Philippe. I reviewed your patch and it looks good to me. In order to simplify integrator's life, could you rebase your patch onto the current stables? The only branches we need are 2.2, 2.3 and master. Oh, and if you could rephrase your commit message for it to start with ' MDL-31516 Gradebook: ' that'd be awesome. Thanks!
          Hide
          Jean-Philippe Gaudreau added a comment -

          Hi Frédéric,

          I've rebased the patch for the current stables 22, 23 and master. I also changed the commit message.
          Hope everything is fine!

          Show
          Jean-Philippe Gaudreau added a comment - Hi Frédéric, I've rebased the patch for the current stables 22, 23 and master. I also changed the commit message. Hope everything is fine!
          Hide
          Frédéric Massart added a comment -

          Thanks Jean-Philippe. I am pushing your patch for integration. You could have added the code area in your commit message but I guess it is fine like this. More information here: http://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages

          Thank you!

          Show
          Frédéric Massart added a comment - Thanks Jean-Philippe. I am pushing your patch for integration. You could have added the code area in your commit message but I guess it is fine like this. More information here: http://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages Thank you!
          Hide
          Jean-Philippe Gaudreau added a comment -

          Ok good thx for the information!

          Show
          Jean-Philippe Gaudreau added a comment - Ok good thx for the information!
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          This has been integrated now. Thanks everyone.

          Show
          Sam Hemelryk added a comment - This has been integrated now. Thanks everyone.
          Hide
          Adrian Greeve added a comment -

          Tested in 2.2, 2.3 and master. Works as it should in all branches.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested in 2.2, 2.3 and master. Works as it should in all branches. Test passed.
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: