Moodle
  1. Moodle
  2. MDL-31528

Bread crumbs (navigation bar) are disappearing when we turn editing off.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Navigation, Themes
    • Labels:
    • Rank:
      38081

      Description

      Bread crumbs are disappearing when we turn off editing. When editing is on the bread crumbs are visible.
      I have attached a document with two screen shots which show what i am referring to.

      1. Bread crumbs.docx
        60 kB
        Brendan Barlow
      2. formal_white.css
        7 kB
        Brendan Barlow
      3. formal css live.docx
        15 kB
        Brendan Barlow

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Hi, Brendan.

          I suspect this has to do with the them you are using. I don't recognise it from the limited screenshots you attached, so I assume it's not standard; let me know if I'm wrong.

          Could you try changing the theme to see if the problem persists.

          Show
          Michael de Raadt added a comment - Hi, Brendan. I suspect this has to do with the them you are using. I don't recognise it from the limited screenshots you attached, so I assume it's not standard; let me know if I'm wrong. Could you try changing the theme to see if the problem persists.
          Hide
          Brendan Barlow added a comment - - edited

          Hi Michael,We are using formal white theme with customised css. I will check with the boss to see if we can change the theme on the Dev. If it is the theme do you have any thoughts?

          Show
          Brendan Barlow added a comment - - edited Hi Michael,We are using formal white theme with customised css. I will check with the boss to see if we can change the theme on the Dev. If it is the theme do you have any thoughts?
          Hide
          Michael de Raadt added a comment -

          If it is the theme, then it could be the case that the container for the breadcrumbs is being hidden or not included in certain page layouts.

          If it's not the theme, then we would really need a few more clues to see why this is happening on your site but not others.

          Show
          Michael de Raadt added a comment - If it is the theme, then it could be the case that the container for the breadcrumbs is being hidden or not included in certain page layouts. If it's not the theme, then we would really need a few more clues to see why this is happening on your site but not others.
          Hide
          Brendan Barlow added a comment - - edited

          Michael,
          We have upgraded to Moodle 2.2.1+ (Build: 20120127) last week.
          I have uploaded our formal white css code.
          It does not seem to be our customised formal white theme as it is also occuring in sky high theme.
          I have made a demonstration of changing the theme. It is 2 formats.
          https://share.tafensw.edu.au/share/file/237e4975-9985-4b17-a28f-d86568e23802/1/breadcrumbs/Breadcrumb%20disappearance%20in%20Moodle%202.2.1.htm
          https://share.tafensw.edu.au/share/file/237e4975-9985-4b17-a28f-d86568e23802/1/breadcrumbs/Breadcrumb%20disappearance%20in%20Moodle%202.2.1.pdf
          Is there any more information you require.
          Thanks

          Show
          Brendan Barlow added a comment - - edited Michael, We have upgraded to Moodle 2.2.1+ (Build: 20120127) last week. I have uploaded our formal white css code. It does not seem to be our customised formal white theme as it is also occuring in sky high theme. I have made a demonstration of changing the theme. It is 2 formats. https://share.tafensw.edu.au/share/file/237e4975-9985-4b17-a28f-d86568e23802/1/breadcrumbs/Breadcrumb%20disappearance%20in%20Moodle%202.2.1.htm https://share.tafensw.edu.au/share/file/237e4975-9985-4b17-a28f-d86568e23802/1/breadcrumbs/Breadcrumb%20disappearance%20in%20Moodle%202.2.1.pdf Is there any more information you require. Thanks
          Hide
          Michael de Raadt added a comment -

          Hi, Brendan.

          Thanks for providing that additional information.

          Two ideas come to mind now.

          1. It could still be a theme if the "base" theme was changed. This would affect all themes.
          2. It could be something to do with the custom menu, but that's not as likely.

          It would be good to check how your Theme settings (Site admin > Appearance > Themes > Theme settings) differ from the defaults.

          It would be good to see the HTML source produced on your page. It seems to me that there may be a hidden container opening before the breadcrumbs, but not being closed, and so the end of the breadcrumbs is being used as the end of the hidden section.

          Show
          Michael de Raadt added a comment - Hi, Brendan. Thanks for providing that additional information. Two ideas come to mind now. It could still be a theme if the "base" theme was changed. This would affect all themes. It could be something to do with the custom menu, but that's not as likely. It would be good to check how your Theme settings (Site admin > Appearance > Themes > Theme settings) differ from the defaults. It would be good to see the HTML source produced on your page. It seems to me that there may be a hidden container opening before the breadcrumbs, but not being closed, and so the end of the breadcrumbs is being used as the end of the hidden section.
          Hide
          Michael de Raadt added a comment -

          Hi, Mary.

          I'm wondering if you could have a quick look a the problem Brendan is having? Perhaps with your more extensive Theme knowledge, something might jump out at you.

          Show
          Michael de Raadt added a comment - Hi, Mary. I'm wondering if you could have a quick look a the problem Brendan is having? Perhaps with your more extensive Theme knowledge, something might jump out at you.
          Hide
          Mary Evans added a comment -

          Hi Brenden,

          Did this problem occur prior to your making the changes? If so then you have errors in your code. First you could try validating the style-sheets, where you have made changes, using the W3C Validator which you will find at http://jigsaw.w3.org/css-validator/#validate_by_upload - the main things to look out for are PARSE errors.

          Could you also upload the general.php you are using as this may hold clues to the problem?

          Thanks

          Show
          Mary Evans added a comment - Hi Brenden, Did this problem occur prior to your making the changes? If so then you have errors in your code. First you could try validating the style-sheets, where you have made changes, using the W3C Validator which you will find at http://jigsaw.w3.org/css-validator/#validate_by_upload - the main things to look out for are PARSE errors. Could you also upload the general.php you are using as this may hold clues to the problem? Thanks
          Hide
          Mary Evans added a comment -

          @Michael

          It looks like this is a layout problem, I would hazard a guess and say the breadcrumbs have fallen onto the floor! In other words they have slipped off the top and behind the main content. I have a feeling the page shifts down in editing and shifts back up when editing is off. However this should not have affected the navebar if space has been allocated to it.

          Show
          Mary Evans added a comment - @Michael It looks like this is a layout problem, I would hazard a guess and say the breadcrumbs have fallen onto the floor! In other words they have slipped off the top and behind the main content. I have a feeling the page shifts down in editing and shifts back up when editing is off. However this should not have affected the navebar if space has been allocated to it.
          Hide
          Mary Evans added a comment -

          OK...joking apart, it would appear that this is a feature as it is set this way in Base theme. I've not checked Moodle 1.9 to see if it works in the same way, but will do later.

          Show
          Mary Evans added a comment - OK...joking apart, it would appear that this is a feature as it is set this way in Base theme. I've not checked Moodle 1.9 to see if it works in the same way, but will do later.
          Hide
          Brendan Barlow added a comment -

          Hi Mary,
          I have uploaded the frontpageHTML source and general php.
          These errors only appeared after the upgrade.
          How and where can I access the style sheets.
          Thanks

          Show
          Brendan Barlow added a comment - Hi Mary, I have uploaded the frontpageHTML source and general php. These errors only appeared after the upgrade. How and where can I access the style sheets. Thanks
          Hide
          Brendan Barlow added a comment - - edited

          Hi,
          I have also added the validation sheet report, formal white css style.
          Thanks

          Show
          Brendan Barlow added a comment - - edited Hi, I have also added the validation sheet report, formal white css style. Thanks
          Hide
          Mary Evans added a comment - - edited

          I am sorry Brenden I think you misunderstood what I was asking you to do.

          I had hoped too that you had seen my last comment here to say that this is a Moodle feature and not a BUG as such.

          I have looked at how it looks in the main parent themes in Moodle 2.2 and Moodle 2.1.3 & also Moodle 1.9.16.

          The navbar/breadcrumbs is visible in Moodle 1.9 but the sidebars are not until you turn editing on. Which is opposite, in a way, to what happens in Moodle 2.x.x, here you get the sidebars but not the navbar/breadcrumbs until you turn on editing.

          I looked at the code which triggers this and found it's set that way, so I guess it's NOT a bug...but could be!

          Perhaps this needs to be looked at...as there may be a reason behind it not being visible.

          You might be better to delete the files you added as you appear to have uploaded folders rather than just files! Or are they part of Docx files? I don't know, but whatever you uploaded there's an aweful lot of stuff there just the same.

          Thanks for bringing this problem to the fore.

          Show
          Mary Evans added a comment - - edited I am sorry Brenden I think you misunderstood what I was asking you to do. I had hoped too that you had seen my last comment here to say that this is a Moodle feature and not a BUG as such. I have looked at how it looks in the main parent themes in Moodle 2.2 and Moodle 2.1.3 & also Moodle 1.9.16. The navbar/breadcrumbs is visible in Moodle 1.9 but the sidebars are not until you turn editing on. Which is opposite, in a way, to what happens in Moodle 2.x.x, here you get the sidebars but not the navbar/breadcrumbs until you turn on editing. I looked at the code which triggers this and found it's set that way, so I guess it's NOT a bug...but could be! Perhaps this needs to be looked at...as there may be a reason behind it not being visible. You might be better to delete the files you added as you appear to have uploaded folders rather than just files! Or are they part of Docx files? I don't know, but whatever you uploaded there's an aweful lot of stuff there just the same. Thanks for bringing this problem to the fore.
          Hide
          Michael de Raadt added a comment -

          Hi, Brendan.

          The HTML source your provided appears to be incomplete. We would need the source of the entire page.

          Show
          Michael de Raadt added a comment - Hi, Brendan. The HTML source your provided appears to be incomplete. We would need the source of the entire page.
          Hide
          Brendan Barlow added a comment -

          Michael, this is the user edited component of the front page. Can you advise to the HTML source you require.
          Thanks

          Show
          Brendan Barlow added a comment - Michael, this is the user edited component of the front page. Can you advise to the HTML source you require. Thanks
          Hide
          Brendan Barlow added a comment -

          Mary, If this is a feature of Moodle 2+ Can we change this ticket to an improvement or do we I need to create a new ticket and link this to the new ticket.
          In regards to the folders, which folders are you refereeing to?
          Thanks

          Show
          Brendan Barlow added a comment - Mary, If this is a feature of Moodle 2+ Can we change this ticket to an improvement or do we I need to create a new ticket and link this to the new ticket. In regards to the folders, which folders are you refereeing to? Thanks
          Hide
          Michael de Raadt added a comment -

          Hi, Brendan.

          I was expecting to see the HTML source of your entire page so we could see if the breadcrumbs is present but hidden.

          I'm not quite sure what Mary means but this disappearance of the breadcrumbs is not normal in recent versions of Moodle, but perhaps it is possible to turn the bar off in the theme if you modify it (or the base theme).

          Show
          Michael de Raadt added a comment - Hi, Brendan. I was expecting to see the HTML source of your entire page so we could see if the breadcrumbs is present but hidden. I'm not quite sure what Mary means but this disappearance of the breadcrumbs is not normal in recent versions of Moodle, but perhaps it is possible to turn the bar off in the theme if you modify it (or the base theme).
          Hide
          Mary Evans added a comment -

          @ Michael

          I have just added some Test Instructions. I replicated this problem in course CATEGORY but since I have never had occasion to be looking in a category, and cannot say if I have ever noticed the navbar there or not, as I would normally go straight to a course. It looks like the navbar is visible in courses, but not categories, which is odd. But if you look at the code for categories it appears it has been set that way for a reason.

          Show
          Mary Evans added a comment - @ Michael I have just added some Test Instructions. I replicated this problem in course CATEGORY but since I have never had occasion to be looking in a category, and cannot say if I have ever noticed the navbar there or not, as I would normally go straight to a course. It looks like the navbar is visible in courses, but not categories, which is odd. But if you look at the code for categories it appears it has been set that way for a reason.
          Hide
          Mary Evans added a comment -

          @Brendan

          Sorry for the confusion. The documents you added have grey arrows at the side of them this opens up into a list, but I realised these are the files associated with the DocX documents. So no worries.

          As for general.php & frontpage.php these are two files in the Formal White theme and found in the following location: moodle/theme/formal_white/layout/general.php where you will also find frontpage.php.

          The generalphp.txt you added is in actual fact the config.php for your organisation. This needs removing as there may be sensative information in that file which is better not made public. I don;t think we need any HTML at all as I have replicated this BUG and that apparently is what it is. It's not an IMPROVEMENT so I wont be converting this issue into one.

          OK...just to recap.
          Can you please remove the two txt files generalphp.txt and frontpagephp.txt as these are of no use to us. To be truthful, the CSS view you added is not needed either. The only reason I asked you to validate the CSS was to find out if there was an error in the stylesheets which had been modified. I also assumed you were the web designer/developer for your organisation, and as such would be familiar with the theme, and its associated files and directories. It is obvious that you are not and, so again I am sorry for compounding the confusion by asking for files, when you probably had no clue what they were, let alone where they were likely to be.

          Anyway...everything is OK and we shall be getting this fixed soon.

          Show
          Mary Evans added a comment - @Brendan Sorry for the confusion. The documents you added have grey arrows at the side of them this opens up into a list, but I realised these are the files associated with the DocX documents. So no worries. As for general.php & frontpage.php these are two files in the Formal White theme and found in the following location: moodle/theme/formal_white/layout/general.php where you will also find frontpage.php. The generalphp.txt you added is in actual fact the config.php for your organisation. This needs removing as there may be sensative information in that file which is better not made public. I don;t think we need any HTML at all as I have replicated this BUG and that apparently is what it is. It's not an IMPROVEMENT so I wont be converting this issue into one. OK...just to recap. Can you please remove the two txt files generalphp.txt and frontpagephp.txt as these are of no use to us. To be truthful, the CSS view you added is not needed either. The only reason I asked you to validate the CSS was to find out if there was an error in the stylesheets which had been modified. I also assumed you were the web designer/developer for your organisation, and as such would be familiar with the theme, and its associated files and directories. It is obvious that you are not and, so again I am sorry for compounding the confusion by asking for files, when you probably had no clue what they were, let alone where they were likely to be. Anyway...everything is OK and we shall be getting this fixed soon.
          Hide
          Brendan Barlow added a comment -

          Mary and Michael,
          thanks for your help on this.
          How do I know when it is fixed?
          How do I delete the files I attached?
          Many thanks
          Brendan

          Show
          Brendan Barlow added a comment - Mary and Michael, thanks for your help on this. How do I know when it is fixed? How do I delete the files I attached? Many thanks Brendan
          Hide
          Michael de Raadt added a comment -

          Thanks for working on this Mary. I've set you as the assignee for this issue. You certainly deserve the credit for your work so far.

          I was able to reproduce that problem on the category page.

          I've removed the unnecessary attachments. For future reference, there is a little down-facing triangle next to the top of the attachment section that allows you to go to a file management interface.

          Show
          Michael de Raadt added a comment - Thanks for working on this Mary. I've set you as the assignee for this issue. You certainly deserve the credit for your work so far. I was able to reproduce that problem on the category page. I've removed the unnecessary attachments. For future reference, there is a little down-facing triangle next to the top of the attachment section that allows you to go to a file management interface.
          Hide
          Michael de Raadt added a comment -

          Hi, Sam.

          I've added you as a watcher as I thought you might be interested in this issue.

          Show
          Michael de Raadt added a comment - Hi, Sam. I've added you as a watcher as I thought you might be interested in this issue.
          Hide
          Mary Evans added a comment -

          @Sam

          It appears that the navbar has been coded into moodle/course/category.php not to show until editing in enabled. Why is this? Can it be reversed or is there a specific reason for this?

          Cheers
          Mary

          Show
          Mary Evans added a comment - @Sam It appears that the navbar has been coded into moodle/course/category.php not to show until editing in enabled. Why is this? Can it be reversed or is there a specific reason for this? Cheers Mary
          Hide
          Mary Evans added a comment -

          @Brendan

          When this is being fixed the status of this page changes to Development in Progress, then Peer Review or Integration Review, and if accepted it is then CLOSED and marked as FIXED. At or about this time the Integrator sends a message to all issues that are fixed in a specific version of Moodle that that version is now available for download, or words to that effect.

          Show
          Mary Evans added a comment - @Brendan When this is being fixed the status of this page changes to Development in Progress, then Peer Review or Integration Review, and if accepted it is then CLOSED and marked as FIXED. At or about this time the Integrator sends a message to all issues that are fixed in a specific version of Moodle that that version is now available for download, or words to that effect.
          Hide
          Brendan Barlow added a comment -

          Mary
          Thanks for your help. When i created this issue it was the first time i was on this site.
          Thanks again.

          Regards
          Brendan

          Show
          Brendan Barlow added a comment - Mary Thanks for your help. When i created this issue it was the first time i was on this site. Thanks again. Regards Brendan
          Hide
          Mary Evans added a comment - - edited

          Hi Brendan,
          I've just been testing this again, and it appears to be fixed in Moodle 2.2.1 latest version as I cannot replicate the problem, but can in Moodle 2.1.3

          Can you test something for me? Go to Site Administration > Appearance > Themes > Theme settings and remove the custommenu items (obviously you will need to make a copy of the Menu text so that you can add it back after testing.)

          After removing the menu items in Themes settings SAVE the changes and return to the Category page and see if the navbar appears.

          Let me know how you get on.

          Thanks
          Mary

          Show
          Mary Evans added a comment - - edited Hi Brendan, I've just been testing this again, and it appears to be fixed in Moodle 2.2.1 latest version as I cannot replicate the problem, but can in Moodle 2.1.3 Can you test something for me? Go to Site Administration > Appearance > Themes > Theme settings and remove the custommenu items (obviously you will need to make a copy of the Menu text so that you can add it back after testing.) After removing the menu items in Themes settings SAVE the changes and return to the Category page and see if the navbar appears. Let me know how you get on. Thanks Mary
          Hide
          Brendan Barlow added a comment - - edited
          Show
          Brendan Barlow added a comment - - edited Hi Mary, I made a copy and then tested. The navbar was visible while editing was on and off. Here is a sample https://share.tafensw.edu.au/share/file/237e4975-9985-4b17-a28f-d86568e23802/1/breadcrumbs/nav%20bar%20test.htm https://share.tafensw.edu.au/share/file/237e4975-9985-4b17-a28f-d86568e23802/1/breadcrumbs/nav%20bar%20test.swf Regards Brendan
          Hide
          Mary Evans added a comment -

          Hi Brenden

          What version of Moodle are you using?

          Show
          Mary Evans added a comment - Hi Brenden What version of Moodle are you using?
          Hide
          Mary Evans added a comment -

          @Michael

          Which version of Moodle did you test this on as I now find it works OK in Moodle 2.2.1 but not 2.1.3

          Show
          Mary Evans added a comment - @Michael Which version of Moodle did you test this on as I now find it works OK in Moodle 2.2.1 but not 2.1.3
          Hide
          Brendan Barlow added a comment -

          Mary/Michael,
          we are using V2.2.1
          Regards
          Brendan

          Show
          Brendan Barlow added a comment - Mary/Michael, we are using V2.2.1 Regards Brendan
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          I've linked two issues that are very much in line with this issue.

          There are a couple of bugs with the navbar when in a category context that are leading to what you are seeing whereby categories aren't being shown in the navbar, or the wrong category is being highlighted depending upon the state of the page.

          Mary do you have changes pending for this issue?

          I have a fix to purpose for this, I am thinking if you have also got changes I will use one of the linked issues that way you can make your changes here and I'll use another issue to keep things cleaner.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I've linked two issues that are very much in line with this issue. There are a couple of bugs with the navbar when in a category context that are leading to what you are seeing whereby categories aren't being shown in the navbar, or the wrong category is being highlighted depending upon the state of the page. Mary do you have changes pending for this issue? I have a fix to purpose for this, I am thinking if you have also got changes I will use one of the linked issues that way you can make your changes here and I'll use another issue to keep things cleaner. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          My purposed changes: https://github.com/samhemelryk/moodle/compare/master...wip-MDL-31528-m23
          Note: The diffs are much bigger than the changes because of white space changes. If you apply it you'll find I've only changed a fraction of the lines.

          Show
          Sam Hemelryk added a comment - My purposed changes: https://github.com/samhemelryk/moodle/compare/master...wip-MDL-31528-m23 Note: The diffs are much bigger than the changes because of white space changes. If you apply it you'll find I've only changed a fraction of the lines.
          Hide
          Brendan Barlow added a comment - - edited

          Sam,
          Thanks for the information regarding this.
          Regards
          Brendan

          Show
          Brendan Barlow added a comment - - edited Sam, Thanks for the information regarding this. Regards Brendan
          Hide
          Mary Evans added a comment -

          @Sam,
          I have just read your comment asking if I have any commits for this issue. The answer is no...you are free to use this if it helps?

          I'll assign it to you then you can decide if you want to use this or one of the others.
          Cheers

          Show
          Mary Evans added a comment - @Sam, I have just read your comment asking if I have any commits for this issue. The answer is no...you are free to use this if it helps? I'll assign it to you then you can decide if you want to use this or one of the others. Cheers
          Hide
          Brendan Barlow added a comment -

          HI,
          we can look at testing the patch locally, but it is not causing a big issue for us at the moment.
          Will this be rectified in 2.3? If so we will prob wait til then.
          Regards
          Brendan

          Show
          Brendan Barlow added a comment - HI, we can look at testing the patch locally, but it is not causing a big issue for us at the moment. Will this be rectified in 2.3? If so we will prob wait til then. Regards Brendan
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - I'm putting this up for integration shortly.
          The solution I've got appears to fix this issue as well as several others that have been reported about the categories navigation and navbar issues.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Mary - I'm putting this up for integration shortly. The solution I've got appears to fix this issue as well as several others that have been reported about the categories navigation and navbar issues. Cheers Sam
          Hide
          Dan Poltawski added a comment -

          Hi Sam,

          Looks good to me. Only comment is that you are using context_instance_preload_sql which has a deprecated phpdoc tag added in e922fe23 - from the looks of that seems like Petr may have mistakenly added the tag.

          Show
          Dan Poltawski added a comment - Hi Sam, Looks good to me. Only comment is that you are using context_instance_preload_sql which has a deprecated phpdoc tag added in e922fe23 - from the looks of that seems like Petr may have mistakenly added the tag.
          Hide
          Sam Hemelryk added a comment -

          Hi Dan,

          Good spotting!
          I am a big fan of the context instance preloading but I had completely missed that they had been deprecated (presumably in Petr's enrolment rewrite or 2.2)
          I can see how context_instance_preload is straight switch of course but context_instance_preload_sql certainly looks friendly then its new alternative.
          I'll see if I can catch Petr later on today/tomorrow and just confirm it has been deprecated. If so no probs I'll convert this code, I'll also look to create an issue to convert several other areas on a role.

          Leaving this as development in process for the time being.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Dan, Good spotting! I am a big fan of the context instance preloading but I had completely missed that they had been deprecated (presumably in Petr's enrolment rewrite or 2.2) I can see how context_instance_preload is straight switch of course but context_instance_preload_sql certainly looks friendly then its new alternative. I'll see if I can catch Petr later on today/tomorrow and just confirm it has been deprecated. If so no probs I'll convert this code, I'll also look to create an issue to convert several other areas on a role. Leaving this as development in process for the time being. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Putting this up for integration now.
          I've converted the calls to context_instance_preload and context_instance_preload_sql in master now.
          I've done it in master only to minimise the chance of regressions.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Putting this up for integration now. I've converted the calls to context_instance_preload and context_instance_preload_sql in master now. I've done it in master only to minimise the chance of regressions. Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some hours ago...

          the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Brendan Barlow added a comment -

          Hi Eloy,

          Does this mean that missing breadcrumbs will be rectified in Version 2.2.2? or a later version?

          Show
          Brendan Barlow added a comment - Hi Eloy, Does this mean that missing breadcrumbs will be rectified in Version 2.2.2? or a later version?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Hi Brendan,

          as far as it has not been integrated yet (and surely won't be until next week - March 22th) you will need to update to Moodle 2.2.2+ after that date.

          Once this is closed, in <24h, the new version (weekly) including all the changes is created.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Hi Brendan, as far as it has not been integrated yet (and surely won't be until next week - March 22th) you will need to update to Moodle 2.2.2+ after that date. Once this is closed, in <24h, the new version (weekly) including all the changes is created. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Increasing the priority of this issue, there are now several duplicates.
          It is up for integration and will hopefully go in next week.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Increasing the priority of this issue, there are now several duplicates. It is up for integration and will hopefully go in next week. Cheers Sam
          Hide
          Aparup Banerjee added a comment -

          Hi Sam,
          Its been awhile since i've looked into navigation, still learning about it. Anyway here's some notes/queries while i had a look in there:

          • global_navigation::initialise() , when process CONTEXT_USER seems like a break; is missing there to avoid re-loading the info.
          • course/category.php : wondering about saving on object re-construction, '$url = new moodle_url()' multiple times with same url begining used (well its only twice here but theres a loop for subcategories) , so that vs -
            $url->remove_all_params();
            $url->param(array('parent'=>$category->id))
            

            also see $baseurl there.

          • category.php : 'movecourses' form --> If you feeling up to it in that area (or maybe a separate issue), make that an mform? might be overkill for that one dropdown but it sure helps consolidate future form security issues.

          looks alright otherwise

          Show
          Aparup Banerjee added a comment - Hi Sam, Its been awhile since i've looked into navigation, still learning about it. Anyway here's some notes/queries while i had a look in there: global_navigation::initialise() , when process CONTEXT_USER seems like a break; is missing there to avoid re-loading the info. course/category.php : wondering about saving on object re-construction, '$url = new moodle_url()' multiple times with same url begining used (well its only twice here but theres a loop for subcategories) , so that vs - $url->remove_all_params(); $url->param(array('parent'=>$category->id)) also see $baseurl there. category.php : 'movecourses' form --> If you feeling up to it in that area (or maybe a separate issue), make that an mform? might be overkill for that one dropdown but it sure helps consolidate future form security issues. looks alright otherwise
          Hide
          Sam Hemelryk added a comment -

          Thanks Apu,

          I've fixed up the missing break in point 1.
          Point 2 I've optimised the moodle_url code a little now, it still initialises within the loop however not as much as it did before, I don't think this will be too much of a performance hit + see the following point
          Point 3, I'm presently working on re-writing the course and category management for 2.3, it will see all of these scripts modernised including new mforms and clear separation of functionality.

          All changes made a separate commits and pushed up ready now

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Apu, I've fixed up the missing break in point 1. Point 2 I've optimised the moodle_url code a little now, it still initialises within the loop however not as much as it did before, I don't think this will be too much of a performance hit + see the following point Point 3, I'm presently working on re-writing the course and category management for 2.3, it will see all of these scripts modernised including new mforms and clear separation of functionality. All changes made a separate commits and pushed up ready now Cheers Sam
          Hide
          Aparup Banerjee added a comment -

          Thanks, thats been integrated and is up for testing.

          Sam: thanks, every little bit helps .

          Show
          Aparup Banerjee added a comment - Thanks, thats been integrated and is up for testing. Sam: thanks, every little bit helps .
          Hide
          Adrian Greeve added a comment -

          This tested fine in master, but when I switched editing off in the course creation page, in version 2.2 and 2.1, I got the following error:

          Fatal error: Class 'lang_string' not found in /var/www/repositories/integration/MOODLE_22_STABLE/moodle/course/category.php on line 265

          I believe that lang_string() might be a 2.3 introduction and doesn't exist in 2.2 and 2.1

          Everything else works fine.

          Show
          Adrian Greeve added a comment - This tested fine in master, but when I switched editing off in the course creation page, in version 2.2 and 2.1, I got the following error: Fatal error: Class 'lang_string' not found in /var/www/repositories/integration/MOODLE_22_STABLE/moodle/course/category.php on line 265 I believe that lang_string() might be a 2.3 introduction and doesn't exist in 2.2 and 2.1 Everything else works fine.
          Hide
          Sam Hemelryk added a comment - - edited

          Thanks Adrian, I'll fix up the lang_string use in 22 now and then reopen for testing

          Show
          Sam Hemelryk added a comment - - edited Thanks Adrian, I'll fix up the lang_string use in 22 now and then reopen for testing
          Hide
          Sam Hemelryk added a comment -

          And its up for testing again. Fixed in 22 and 21.
          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - And its up for testing again. Fixed in 22 and 21. Cheers Sam
          Hide
          Adrian Greeve added a comment -

          Tested again. All working fine.
          Thanks Sam.

          Show
          Adrian Greeve added a comment - Tested again. All working fine. Thanks Sam.
          Hide
          Rossiani Wijaya added a comment -

          Hi Sam and Adrian,

          While testing MDL-32004, I found regression error for viewing category courses (in 2.1).

          Fatal error: Call to undefined function get_course_display_name_for_list() in /m21/course/category.php on line 343

          To reproduce:

          admin setting > courses > add/edit courses > select a categories from 'course categories' column.

          Show
          Rossiani Wijaya added a comment - Hi Sam and Adrian, While testing MDL-32004 , I found regression error for viewing category courses (in 2.1). Fatal error: Call to undefined function get_course_display_name_for_list() in /m21/course/category.php on line 343 To reproduce: admin setting > courses > add/edit courses > select a categories from 'course categories' column.
          Hide
          Rossiani Wijaya added a comment -

          PS:

          MDL-29719: get_course_display_name_for_list() was added to 2.2

          Show
          Rossiani Wijaya added a comment - PS: MDL-29719 : get_course_display_name_for_list() was added to 2.2
          Hide
          Ankit Agarwal added a comment - - edited

          Ignore my previous comment, just noticed the lang_string issue has been already fixed.
          Thanks Sam for quick fix

          Show
          Ankit Agarwal added a comment - - edited Ignore my previous comment, just noticed the lang_string issue has been already fixed. Thanks Sam for quick fix
          Hide
          Sam Hemelryk added a comment -

          Thanks for spotting that Rosie, I've pushed a fix up now.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks for spotting that Rosie, I've pushed a fix up now. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Congratulations are in order, you've made it, or at least your code has!
          It's now part of Moodle and both the git and cvs repositories have been updated.

          This issue is being marked as fixed and closed.

          Thank you.

          Show
          Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.
          Hide
          Marc Kowal added a comment - - edited

          Possibly Breadcrumbs disapearing again in 2.3.2 (20120910).

          Updated from 1.9 -> 2.0 -> 2.1 -> 2.2 -> 2.3 - No breadcrumbs after turning off editing in course/category.php?id=XXXX ?! Can someone have a look at this again please?

          Show
          Marc Kowal added a comment - - edited Possibly Breadcrumbs disapearing again in 2.3.2 (20120910). Updated from 1.9 -> 2.0 -> 2.1 -> 2.2 -> 2.3 - No breadcrumbs after turning off editing in course/category.php?id=XXXX ?! Can someone have a look at this again please?
          Hide
          Mary Evans added a comment -

          Before I open a new tracker issue for this regression, can you please check to see the problem is still happening in Standard theme?
          Thanks

          Show
          Mary Evans added a comment - Before I open a new tracker issue for this regression, can you please check to see the problem is still happening in Standard theme? Thanks

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: