Moodle
  1. Moodle
  2. MDL-31546

Semicolon in SQL breaks wiki 'Administration' tab on Oracle

    Details

    • Database:
      Oracle
    • Testing Instructions:
      Hide

      1/ Create a wiki activity in a course
      2/ Add a page
      3/ Click the administration tab
      Expected Result:
      Admin page with menu and list of orphaned apge
      Actual Result
      Oracle DB error

      Show
      1/ Create a wiki activity in a course 2/ Add a page 3/ Click the administration tab Expected Result: Admin page with menu and list of orphaned apge Actual Result Oracle DB error
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31546-master
    • Rank:
      38101

      Description

      A semicolon at the end of the SQL query in wiki_get_orphaned_pages() causes an exception on Oracle. Patch attached.

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for spotting that and sharing a solution, Jonathon.

        Show
        Michael de Raadt added a comment - Thanks for spotting that and sharing a solution, Jonathon.
        Hide
        Dan Poltawski added a comment -

        Submitting for integration

        Show
        Dan Poltawski added a comment - Submitting for integration
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (21, 22 and master)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 and master)
        Hide
        Aparup Banerjee added a comment -

        yup replicated and tested to be fixed.
        passing!

        Show
        Aparup Banerjee added a comment - yup replicated and tested to be fixed. passing!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Well,

        I wish I said it every time
        you do the things you do.
        You always lend a helping hand,
        and I'm filled with gratitude.

        You are strong and generous
        for each and everyone one of us.
        I am eternally grateful,
        I cannot say thanks enough.

        Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: