Moodle
  1. Moodle
  2. MDL-31546

Semicolon in SQL breaks wiki 'Administration' tab on Oracle

    Details

    • Database:
      Oracle
    • Testing Instructions:
      Hide

      1/ Create a wiki activity in a course
      2/ Add a page
      3/ Click the administration tab
      Expected Result:
      Admin page with menu and list of orphaned apge
      Actual Result
      Oracle DB error

      Show
      1/ Create a wiki activity in a course 2/ Add a page 3/ Click the administration tab Expected Result: Admin page with menu and list of orphaned apge Actual Result Oracle DB error
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31546-master
    • Rank:
      38101

      Description

      A semicolon at the end of the SQL query in wiki_get_orphaned_pages() causes an exception on Oracle. Patch attached.

        Activity

        Jonathon Fowler created issue -
        Jonathon Fowler made changes -
        Field Original Value New Value
        Attachment MDL-31546-stray-semicolon.patch [ 26704 ]
        Michael de Raadt made changes -
        Fix Version/s STABLE backlog [ 10463 ]
        Priority Minor [ 4 ] Major [ 3 ]
        Labels patch triaged
        Difficulty Easy [ 10023 ]
        Dan Poltawski made changes -
        Status Open [ 1 ] Waiting for integration review [ 10010 ]
        Pull Master Diff URL https://github.com/danpoltawski/moodle/compare/MDL-31546-master
        Pull Master Branch MDL-31546-master
        Pull from Repository git://github.com/danpoltawski/moodle.git
        Peer reviewer poltawski
        Testing Instructions 1/ Create a wiki activity in a course
        2/ Add a page
        3/ Click the administration tab
        Expected Result:
        Admin page with menu and list of orphaned apge
        Actual Result
        Oracle DB error
        Pull 2.1 Branch MDL-31546-21_STABLE
        Pull 2.2 Diff URL https://github.com/danpoltawski/moodle/compare/moodle:MOODLE_22_STABLE...MDL-31546
        Pull 2.1 Diff URL https://github.com/danpoltawski/moodle/compare/moodle:MOODLE_21_STABLE...MDL-31546-21_STABLE
        Pull 2.2 Branch MDL-31546
        Dan Poltawski made changes -
        Assignee moodle.com [ moodle.com ] Dan Poltawski [ poltawski ]
        Eloy Lafuente (stronk7) made changes -
        Currently in integration Yes [ 10041 ]
        Eloy Lafuente (stronk7) made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Integrator stronk7
        Eloy Lafuente (stronk7) made changes -
        Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
        Fix Version/s 2.1.5 [ 11553 ]
        Fix Version/s 2.2.2 [ 11552 ]
        Fix Version/s STABLE backlog [ 10463 ]
        Michael de Raadt made changes -
        Tester abgreeve
        Aparup Banerjee made changes -
        Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
        Tester abgreeve nebgor
        Aparup Banerjee made changes -
        Status Testing in progress [ 10011 ] Tested [ 10006 ]
        Eloy Lafuente (stronk7) made changes -
        Status Tested [ 10006 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Currently in integration Yes [ 10041 ]
        Integration date 01/Mar/12

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: