Moodle
  1. Moodle
  2. MDL-31561

Common cartridge export does not honour the number of sections in exported course

    Details

    • Testing Instructions:
      Hide

      Before applying the patch:
      1. Create an empty course with 20 sections
      2. Edit course settings and change section number to 16
      3. Export course to common cartridge
      4. Exported course will have 20 sections in the manifest instead of 16 as it should

      After applying the patch:
      1. Create an empty course with 20 sections
      2. Edit course settings and change section number to 16
      3. Export course to common cartridge
      4. Exported course will have 16 sections in the manifest

      Show
      Before applying the patch: 1. Create an empty course with 20 sections 2. Edit course settings and change section number to 16 3. Export course to common cartridge 4. Exported course will have 20 sections in the manifest instead of 16 as it should After applying the patch: 1. Create an empty course with 20 sections 2. Edit course settings and change section number to 16 3. Export course to common cartridge 4. Exported course will have 16 sections in the manifest
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      38115

      Description

      Extra sections in course:
      When a course has more sections attached to it than the number of defined sections these sections are being exported with common cartridge.

      This happens when user creates a course with one number of sections and later on decides to change that number to a lower one. In those cases Moodle does not delete extra sections and they become sort of orphaned.

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        Hi Darko, just for clarification, about the testing instructions:

        • The last point, once the patch is applied, is to get only 16 sections in the export, correct? Before the patch they were 20.
        Show
        Eloy Lafuente (stronk7) added a comment - Hi Darko, just for clarification, about the testing instructions: The last point, once the patch is applied, is to get only 16 sections in the export, correct? Before the patch they were 20.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Ping,

        Darko can you confirm / amend the testing instructions to define the expected behavior once the patch is integrated?

        Show
        Eloy Lafuente (stronk7) added a comment - Ping, Darko can you confirm / amend the testing instructions to define the expected behavior once the patch is integrated?
        Hide
        Darko Miletic added a comment -

        Better?

        Show
        Darko Miletic added a comment - Better?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sure man! Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Sure man! Thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (22 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (22 & master), thanks!
        Hide
        Andrew Davis added a comment -

        Works as described. Passing.

        Show
        Andrew Davis added a comment - Works as described. Passing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some changes to Moodle should be milestones in the project by themselves.

        This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: