Moodle
  1. Moodle
  2. MDL-31562

Labels are not being exported in common cartridge format even though their import is supported.

    Details

    • Testing Instructions:
      Hide

      Before applying the patch:
      1. Create an empty course
      2. Add few labels
      3. Export to common cartridge
      4. No items with label titles will be available in package manifest

      After applying the patch
      1. Create an empty course
      2. Add few labels
      3. Export to common cartridge
      4. Items with label title will be available in the manifest. (To see the content of the manifest download the imscc file to the disk, change the extension to zip. Unpack and view the content of imsmanifest.xml)

      Show
      Before applying the patch: 1. Create an empty course 2. Add few labels 3. Export to common cartridge 4. No items with label titles will be available in package manifest After applying the patch 1. Create an empty course 2. Add few labels 3. Export to common cartridge 4. Items with label title will be available in the manifest. (To see the content of the manifest download the imscc file to the disk, change the extension to zip. Unpack and view the content of imsmanifest.xml)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      38116

      Description

      While common cartridge import does support label import it does not support label export. This should be remedied.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          (uhm, same than the other issue. I bet you need to amend the testing instructions to describe the behavior after the patch is applied, hence, "labels will be available in the manifest). That way testers will be able to test this properly.

          TIA and ciao

          PS: In other words, that field is not about "how to reproduce" the problem (that uses to go to the description), but how to test the fix is ok.

          Show
          Eloy Lafuente (stronk7) added a comment - (uhm, same than the other issue. I bet you need to amend the testing instructions to describe the behavior after the patch is applied, hence, "labels will be available in the manifest). That way testers will be able to test this properly. TIA and ciao PS: In other words, that field is not about "how to reproduce" the problem (that uses to go to the description), but how to test the fix is ok.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Ping,

          Darko can you confirm / amend the testing instructions to define the expected behavior once the patch is integrated?

          Show
          Eloy Lafuente (stronk7) added a comment - Ping, Darko can you confirm / amend the testing instructions to define the expected behavior once the patch is integrated?
          Hide
          Darko Miletic added a comment -

          Is this better?

          Show
          Darko Miletic added a comment - Is this better?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Perfect, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Perfect, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks (22 and master).

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks (22 and master).
          Hide
          Andrew Davis added a comment -

          Works as described. In future it would be nice to include more complete set up instructions on how to run the test. I had to ask around to figure out how to turn on the common cartridge export. Passing.

          Show
          Andrew Davis added a comment - Works as described. In future it would be nice to include more complete set up instructions on how to run the test. I had to ask around to figure out how to turn on the common cartridge export. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some changes to Moodle should be milestones in the project by themselves.

          This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: