Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31569

build_activity_plan can be optimized

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Inactive
    • Affects Version/s: 2.2.1
    • Fix Version/s: None
    • Component/s: Backup
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE

      Description

      While working on MDL-25432, I realized while building activity plan (build_activity_plan()), we call get_backup_activity_task which is checking for course module and creates backup_activity_task.
      Also, any backup activity task extends backup_activity_task, in which constructor also checks for course module.

      In get_coursemodule_from_id(), we are making two sql calls. It will be nice to pass coursemodule information in constructor of backup_*_activity_task and we can avoid second redundant check.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rajeshtaneja Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: