Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31590

The title of the header of the dialog that appears when the file selector finds a virus with clamav is incorrect

    XMLWordPrintable

Details

    • MOODLE_21_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MDL-31590-master-1
    • Hide

      Understand english, modify the file filepicker.js

      Show
      Understand english, modify the file filepicker.js
    • Easy
    • Hide

      Setup Instructions

      Ensure that you have a virus checker installed and configured in moodle.
      I installed clamav and clamd and added the following to my config.php:

      $CFG->runclamonupload=1;
      		 
      $CFG->pathtoclam = '/usr/bin/clamdscan';

      Testing Instructions

      • Download the eicar test virus from http://www.eicar.org/85-0-Download.html
      • Open a course and turn editing on
      • Add a new File activity
      • Under 'Select files' choose 'Add'
      • Upload the file and choose the 'Upload this file' button
      • Confirm that you receive an error message with the title 'Error'
        • For extra bonus points try in others languages as the original header was not translatable and should be now
      Show
      Setup Instructions Ensure that you have a virus checker installed and configured in moodle. I installed clamav and clamd and added the following to my config.php: $CFG->runclamonupload=1; $CFG->pathtoclam = '/usr/bin/clamdscan'; Testing Instructions Download the eicar test virus from http://www.eicar.org/85-0-Download.html Open a course and turn editing on Add a new File activity Under 'Select files' choose 'Add' Upload the file and choose the 'Upload this file' button Confirm that you receive an error message with the title 'Error' For extra bonus points try in others languages as the original header was not translatable and should be now

    Description

      Currently, the header of the dialog box uses the wrong variable in the javascript:

      repository/filepicker.js

      		 
      var header = M.str.moodle.info;
      		 
      if (type=='error') {
      		 
        header = M.str.moodle.error;
      		 
      }
      		 
      this.msg_dlg.setHeader(type);

      it should use the variable "header", not type in the setHeader() at line 314 for the version 2.2.1:

      repository/filepicker.js

      		 
      var header = M.str.moodle.info;
      		 
      if (type=='error') {
      		 
        header = M.str.moodle.error;
      		 
      }
      		 
      this.msg_dlg.setHeader(header);

      Attachments

        Activity

          People

            dobedobedoh Andrew Lyons
            leblangi Gilles-Philippe Leblanc
            Dan Poltawski Dan Poltawski
            Sam Hemelryk Sam Hemelryk
            Rossiani Wijaya Rossiani Wijaya
            Ruslan Kabalin, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              12/Mar/12