[MDL-31594] Decimal in manual grading are truncated when using comma - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2.1
Fix Version/s: 2.1.6, 2.2.3
Component/s: Questions, Quiz
Labels:
- triaged
Environment:
Windows 2008 Server

Database:

MySQL
Affected Branches:
MOODLE_22_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-31594~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-31594
Workaround:

Hide

Use point instead of comma and be very careful when editing existing answer.

Show
Use point instead of comma and be very careful when editing existing answer.
Testing Instructions:

Hide

Prerequiste: a weekly course with a student and a teacher. Moodle site set to use lang en.
1- Create a quiz. Make sure "Decimal places in grades" is not zero.
2- Add at least one essay question to the quiz, set it to be marked out of 50.
3- With a student account, complete the quiz and submit it
4- With a teacher account, go to the quiz > results > manual grading
5- Click the Grade link for one of the essay questions.
6- On the Mark field, you should see a blank value
7- Enter the "25,75" value in the Mark field and click Save
8- Go back to the the front page of the manual grading report, and click "Update grades". Make sure the grade is displayed as 25.75.
9- Now save the new grade "35.75" (with a point)
10- Verify that this grade is also saved and displayed correctly.

11- Now switch your language to fr (or any other languages that uses , as a decimal. Repeat steps 4 - 10. The only difference is that Moodle should output grades using , instead of .

Show
Prerequiste: a weekly course with a student and a teacher. Moodle site set to use lang en. 1- Create a quiz. Make sure "Decimal places in grades" is not zero. 2- Add at least one essay question to the quiz, set it to be marked out of 50. 3- With a student account, complete the quiz and submit it 4- With a teacher account, go to the quiz > results > manual grading 5- Click the Grade link for one of the essay questions. 6- On the Mark field, you should see a blank value 7- Enter the "25,75" value in the Mark field and click Save 8- Go back to the the front page of the manual grading report, and click "Update grades". Make sure the grade is displayed as 25.75. 9- Now save the new grade "35.75" (with a point) 10- Verify that this grade is also saved and displayed correctly. 11- Now switch your language to fr (or any other languages that uses , as a decimal. Repeat steps 4 - 10. The only difference is that Moodle should output grades using , instead of .

Description

Using "fr" language pack, when we manually grades an answer, every decimals are truncated if we use the comma. Using the a point instead keep the decimal value correctly. However, once saved using a point, value is then print on screen with a comma, so saving it as is for a second time truncate the decimals again.

Attachments

Issue Links

is duplicated by

MDL-26864 "Make comment or override grade" crashes with certain language settings

Closed

Activity

People

Assignee:: Tim Hunt

Reporter:: JD

Peer reviewer:: Pierre Pichet

Integrator:: Sam Hemelryk

Tester:: Michael de Raadt

Participants:: JD, Michael de Raadt, Pierre Pichet, Sam Hemelryk, Tim Hunt

Component watchers:: Safat Shahin, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo

Votes:: 2 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 11/Feb/12 11:13 AM

Updated:: 13/Sep/12 11:58 PM

Resolved:: 23/Mar/12 5:27 PM

Fix Release Date:: 14/May/12