Moodle
  1. Moodle
  2. MDL-31604

Fix capabilities displayed without spaces causing text going out of the screen

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      In the admin:
      1- Create a service with all functions
      2- add student as authorised users on the service. Check that the missing required capabilities are not displayed over the screen (check the list of authorised user on the page where you can add/remove authorised user)
      2- Create a token for the student
      3- On the admin token pages missing capabilities are also displayed. Check they are not going out of the screen

      Show
      In the admin: 1- Create a service with all functions 2- add student as authorised users on the service. Check that the missing required capabilities are not displayed over the screen (check the list of authorised user on the page where you can add/remove authorised user) 2- Create a token for the student 3- On the admin token pages missing capabilities are also displayed. Check they are not going out of the screen
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31604-attempt3
    • Rank:
      38169

      Description

      Message fomr Eloy:

      Hi Jerome,

      just playing with github a bit... with one real (trivial) pull request.

      Yesterday I was playing with all the WS thing (that I must confess I wasn't able to make it work), and got one nasty message, showing a lot of missing capabilitites and making the browser wider.

      My proposal change is really trivial and fixes that visualization, but I'm lazy to create one complete PULL-X and MDL-X for it, so I'm pulling it to you, just in case you can use any other WS-related fix to introduce this tiny change.

      Ciao

      The fix is there:
      https://github.com/stronk7/moodle/commit/460bee7f471b5562cfa8f5425096405b6290563a

        Issue Links

          Activity

          Hide
          Jérôme Mouneyrac added a comment -

          I marked Eloy as the commit author. I also fixed a similar bug on the fly. Peer reviewed by myself, all good

          Show
          Jérôme Mouneyrac added a comment - I marked Eloy as the commit author. I also fixed a similar bug on the fly. Peer reviewed by myself, all good
          Hide
          Sam Hemelryk added a comment -

          Thanks Jerome this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Jerome this has been integrated now.
          Hide
          Adrian Greeve added a comment -

          Tested in 2.1, 2.2 and master. The orange missing capabilities list is all nicely formated on multiple lines and isn't pushing off the screen.
          Test passed

          Show
          Adrian Greeve added a comment - Tested in 2.1, 2.2 and master. The orange missing capabilities list is all nicely formated on multiple lines and isn't pushing off the screen. Test passed
          Hide
          Eloy Lafuente (stronk7) added a comment -

          It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

          Closing as fixed, heading to zzzZZZzzz, niao

          Show
          Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao
          Hide
          Jérôme Mouneyrac added a comment -

          Ahah funny integration message Eloy

          Show
          Jérôme Mouneyrac added a comment - Ahah funny integration message Eloy

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: