Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31604

Fix capabilities displayed without spaces causing text going out of the screen

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.4, 2.2.1
    • 2.1.5, 2.2.2
    • Web Services
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MDL-31604-attempt3
    • Hide

      In the admin:
      1- Create a service with all functions
      2- add student as authorised users on the service. Check that the missing required capabilities are not displayed over the screen (check the list of authorised user on the page where you can add/remove authorised user)
      2- Create a token for the student
      3- On the admin token pages missing capabilities are also displayed. Check they are not going out of the screen

      Show
      In the admin: 1- Create a service with all functions 2- add student as authorised users on the service. Check that the missing required capabilities are not displayed over the screen (check the list of authorised user on the page where you can add/remove authorised user) 2- Create a token for the student 3- On the admin token pages missing capabilities are also displayed. Check they are not going out of the screen

    Description

      Message fomr Eloy:

      Hi Jerome,

      just playing with github a bit... with one real (trivial) pull request.

      Yesterday I was playing with all the WS thing (that I must confess I wasn't able to make it work), and got one nasty message, showing a lot of missing capabilitites and making the browser wider.

      My proposal change is really trivial and fixes that visualization, but I'm lazy to create one complete PULL-X and MDL-X for it, so I'm pulling it to you, just in case you can use any other WS-related fix to introduce this tiny change.

      Ciao

      The fix is there:
      https://github.com/stronk7/moodle/commit/460bee7f471b5562cfa8f5425096405b6290563a

      Attachments

        Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-31253 META - web service improvements for 2.3

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              jerome Jérôme Mouneyrac
              jerome Jérôme Mouneyrac
              Sam Hemelryk Sam Hemelryk
              Adrian Greeve Adrian Greeve
              Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Mar/12