Moodle
  1. Moodle
  2. MDL-31612

Filepicker is missing iframe support

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.1, 2.8.5
    • Fix Version/s: DEV backlog
    • Component/s: Filepicker
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_28_STABLE

      Description

      In 1.9, it was possible to have a repository plugin which loaded content in an iframe.

      I'm looking at restoring the Nanogong repository plugin to moodle 2, but without this it's not possible to include any custom content of this nature (that I know of).

      The support is missing from repository/filepicker.js

        Gliffy Diagrams

          Activity

          Andrew Nicols created issue -
          Andrew Nicols made changes -
          Field Original Value New Value
          Component/s Repositories [ 10306 ]
          Component/s Files API [ 10305 ]
          Hide
          Michael de Raadt added a comment -

          Thanks for suggesting that.

          Feel free to help us work on this.

          Show
          Michael de Raadt added a comment - Thanks for suggesting that. Feel free to help us work on this.
          Michael de Raadt made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Fix Version/s DEV backlog [ 10464 ]
          Labels triaged
          Assignee moodle.com [ moodle.com ] Dongsheng Cai [ dongsheng ]
          Martin Dougiamas made changes -
          Component/s Filepicker [ 12030 ]
          Component/s Repositories [ 10306 ]
          Hide
          Dongsheng Cai added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.
          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Dongsheng Cai added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Dongsheng Cai made changes -
          Assignee Dongsheng Cai [ dongsheng ]
          Hide
          Jonathan Champ added a comment -

          Just noticed this in Moodle 2.8 while evaluating ForumNG (which uses an iframe for the posts). The code that would normally resize the File Picker at the 873px breakpoint does not appear to work inside of the iframe. The CSS goes into effect, but this causes the display to splinter because the code (possibly JavaScript?) that would normally make the File Picker full size does not appear to be triggering correctly.

          Show
          Jonathan Champ added a comment - Just noticed this in Moodle 2.8 while evaluating ForumNG (which uses an iframe for the posts). The code that would normally resize the File Picker at the 873px breakpoint does not appear to work inside of the iframe. The CSS goes into effect, but this causes the display to splinter because the code (possibly JavaScript?) that would normally make the File Picker full size does not appear to be triggering correctly.
          Jonathan Champ made changes -
          Affects Version/s 2.8.5 [ 14656 ]

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: