Moodle
  1. Moodle
  2. MDL-31627

Arialist theme does not resize content when all blocks are docked

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Themes
    • Labels:
    • Rank:
      38196

      Description

      It leaves the blocks column empty. Empty space remains on the right in 2.2 but shifts to the left in master

        Activity

        Hide
        Martin Dougiamas added a comment -

        Isn't the Partners site on 2.2 though?

        Show
        Martin Dougiamas added a comment - Isn't the Partners site on 2.2 though?
        Hide
        Marina Glancy added a comment -

        Martin: it is on 2.2. I fixed theme in both 2.2 and master. Can be cherry-picked to 2.1 as well if needed

        Show
        Marina Glancy added a comment - Martin: it is on 2.2. I fixed theme in both 2.2 and master. Can be cherry-picked to 2.1 as well if needed
        Hide
        Martin Dougiamas added a comment - - edited

        Sorry, Marina, I read your description as meaning that the bug only was happening on master. I'll patch partners.moodle.com for now.

        Mary, can you check this theme fix and submit it for integration?

        Show
        Martin Dougiamas added a comment - - edited Sorry, Marina, I read your description as meaning that the bug only was happening on master. I'll patch partners.moodle.com for now. Mary, can you check this theme fix and submit it for integration?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Mary Evans added a comment -

        Sorry I seemed to have missed this one!

        It will work as Marina fixed it. But the reason it was not working as it should, is because of way the setting.css is read after pagelayout.css which has the styling for content-only class. However, because the paths are written differently. Default styles in settings.css are taking precedence over content-only, regardless of body class.

        So yes adding .side-post-only will work here as this is a side-post-only theme.

        Cheers
        Mary

        Show
        Mary Evans added a comment - Sorry I seemed to have missed this one! It will work as Marina fixed it. But the reason it was not working as it should, is because of way the setting.css is read after pagelayout.css which has the styling for content-only class. However, because the paths are written differently. Default styles in settings.css are taking precedence over content-only, regardless of body class. So yes adding .side-post-only will work here as this is a side-post-only theme. Cheers Mary
        Hide
        Sam Hemelryk added a comment -

        Fixed repo pull URL

        Show
        Sam Hemelryk added a comment - Fixed repo pull URL
        Hide
        Sam Hemelryk added a comment -

        Thanks Marina - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Marina - this has been integrated now
        Hide
        Rossiani Wijaya added a comment -

        This is working great.

        Thanks everyone.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This is working great. Thanks everyone. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some changes to Moodle should be milestones in the project by themselves.

        This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: