Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31627

Arialist theme does not resize content when all blocks are docked

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Themes
    • Labels:

      Description

      It leaves the blocks column empty. Empty space remains on the right in 2.2 but shifts to the left in master

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            Isn't the Partners site on 2.2 though?

            Show
            dougiamas Martin Dougiamas added a comment - Isn't the Partners site on 2.2 though?
            Hide
            marina Marina Glancy added a comment -

            Martin: it is on 2.2. I fixed theme in both 2.2 and master. Can be cherry-picked to 2.1 as well if needed

            Show
            marina Marina Glancy added a comment - Martin: it is on 2.2. I fixed theme in both 2.2 and master. Can be cherry-picked to 2.1 as well if needed
            Hide
            dougiamas Martin Dougiamas added a comment - - edited

            Sorry, Marina, I read your description as meaning that the bug only was happening on master. I'll patch partners.moodle.com for now.

            Mary, can you check this theme fix and submit it for integration?

            Show
            dougiamas Martin Dougiamas added a comment - - edited Sorry, Marina, I read your description as meaning that the bug only was happening on master. I'll patch partners.moodle.com for now. Mary, can you check this theme fix and submit it for integration?
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            lazydaisy Mary Evans added a comment -

            Sorry I seemed to have missed this one!

            It will work as Marina fixed it. But the reason it was not working as it should, is because of way the setting.css is read after pagelayout.css which has the styling for content-only class. However, because the paths are written differently. Default styles in settings.css are taking precedence over content-only, regardless of body class.

            So yes adding .side-post-only will work here as this is a side-post-only theme.

            Cheers
            Mary

            Show
            lazydaisy Mary Evans added a comment - Sorry I seemed to have missed this one! It will work as Marina fixed it. But the reason it was not working as it should, is because of way the setting.css is read after pagelayout.css which has the styling for content-only class. However, because the paths are written differently. Default styles in settings.css are taking precedence over content-only, regardless of body class. So yes adding .side-post-only will work here as this is a side-post-only theme. Cheers Mary
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Fixed repo pull URL

            Show
            samhemelryk Sam Hemelryk added a comment - Fixed repo pull URL
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Marina - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Marina - this has been integrated now
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This is working great.

            Thanks everyone.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This is working great. Thanks everyone. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Some changes to Moodle should be milestones in the project by themselves.

            This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12