Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31629

auth shibboleth print_error() does not use its own language file

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Since it's not easy to make a working Shibboelth authentication break (messing with attributes or IdP), simply duplicate a "print_error('shib_not_set_up_error', 'auth');" line outside of an condition check to show the broken behavior is the quickest way to test this.

      Show
      Since it's not easy to make a working Shibboelth authentication break (messing with attributes or IdP), simply duplicate a "print_error('shib_not_set_up_error', 'auth');" line outside of an condition check to show the broken behavior is the quickest way to test this.
    • Workaround:
      Hide

      update the module parameter for the 3 print_error calls in auth/shibboleth/index.php from 'auth' to 'auth_shibboleth'.

      Show
      update the module parameter for the 3 print_error calls in auth/shibboleth/index.php from 'auth' to 'auth_shibboleth'.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-31629-master

      Description

      The 3 print_error() calls in auth/shibboleth/index.php should be pulling strings from its own module language file instead of "auth". This results missing error messages when errors occur.

      The fix is to update the module parameter for the 3 print_error calls from 'auth' to 'auth_shibboleth'.

        Attachments

          Activity

            People

            Assignee:
            maherne Michael Aherne
            Reporter:
            davidtang David Tang
            Peer reviewer:
            Dan Poltawski
            Integrator:
            Sam Hemelryk
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Nov/12