Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31635

Course completion "grade" criteria assume all grades are percentages

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Create a course and add 2 assignments each with a grade of 80.
      2. Visit <yoursite>/admin/settings.php?section=optionalsubsystems and enable completion tracking.
      3. Visit the course settings and set 'Completion tracking' to 'Enabled, control via completion and activity settings".
      4. Click on 'Course completion' in the 'Course administration' menu and check to enable the course grade and set it to 80.
      5. Add the 'Course completion status' block.
      6. Log in as a student and submit to each assignment.
      7. As an administrator give each submission a 38/80.
      8. Log back in as a student.
      9. Completion block should show that course is not completed and the grade is 76, and 80 is required (no '%' sign)
      10. Completion report should also not mention any %
      11. Login as teacher and view completion report (make sure there are no %)
      12. Click on student name and, again, make sure there are no %

      Also three other things fixed:
      Error 1 - extra rounding in the form:

      1. Create a course
      2. Go to course completion and add a grade condition with minimum grade 75.99
      3. Save form and open it again
      4. In the grade condition you should see 75.99000 (before fix you'd see 76.0)

      Error 2 - incorrect rounding in the report (always 2 digits):

      1. Create a course
      2. Go to grades settings and set "Overall decimal points" to 3
      3. Go to course completion and add a grade condition 75.111
      4. Make sure course completion report displays 75.111 (and not 75.11 as before fix)
      5. Change setting to 1 or 0 decimal points, this should be respected in both course completion block and report

      Error 3 - number format

      1. switch to language with different decimal separator (French, Russian, etc)
      2. In the previous test make sure that the grade is displayed with a language-specific decimal separator (i.e. comma)
      Show
      Create a course and add 2 assignments each with a grade of 80. Visit <yoursite>/admin/settings.php?section=optionalsubsystems and enable completion tracking. Visit the course settings and set 'Completion tracking' to 'Enabled, control via completion and activity settings". Click on 'Course completion' in the 'Course administration' menu and check to enable the course grade and set it to 80. Add the 'Course completion status' block. Log in as a student and submit to each assignment. As an administrator give each submission a 38/80. Log back in as a student. Completion block should show that course is not completed and the grade is 76, and 80 is required (no '%' sign) Completion report should also not mention any % Login as teacher and view completion report (make sure there are no %) Click on student name and, again, make sure there are no % Also three other things fixed: Error 1 - extra rounding in the form: Create a course Go to course completion and add a grade condition with minimum grade 75.99 Save form and open it again In the grade condition you should see 75.99000 (before fix you'd see 76.0) Error 2 - incorrect rounding in the report (always 2 digits): Create a course Go to grades settings and set "Overall decimal points" to 3 Go to course completion and add a grade condition 75.111 Make sure course completion report displays 75.111 (and not 75.11 as before fix) Change setting to 1 or 0 decimal points, this should be respected in both course completion block and report Error 3 - number format switch to language with different decimal separator (French, Russian, etc) In the previous test make sure that the grade is displayed with a language-specific decimal separator (i.e. comma)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_26_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-31635-master

      Description

      Completion status is looking at total of points (rawgrade) rather than a percentage. However it is also incorrectly displaying as a percentage.

      Reproduction instructions:

      • create a course with one enrolled student and completion enabled
      • in the course completion set "require grade" 80. There is no indication on this screen what is "80" - the total or the %.
      • view course completion report, it displays "Grade: 80% required", so here it is assumed that 80% is required.
      • create one grade item with maximum grade = 200 (or two items with 100 each)
      • grade student with 100 (or twice as 50). In user report it will be displayed that he has 100/200 which is 50%.
      • after cron runs student will be marked as completing the course

        Attachments

        1. completionreport.png
          completionreport.png
          66 kB
        2. completionsetup.png
          completionsetup.png
          29 kB
        3. Screen Shot 2012-02-14 at 1.42.31 PM.png
          Screen Shot 2012-02-14 at 1.42.31 PM.png
          35 kB
        4. studentblock.png
          studentblock.png
          16 kB
        5. studentreport.png
          studentreport.png
          56 kB
        6. usergrades.png
          usergrades.png
          26 kB

          Issue Links

            Activity

              People

              • Votes:
                12 Vote for this issue
                Watchers:
                21 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Mar/16