Moodle
  1. Moodle
  2. MDL-31642

The drag and drop message in the files area shown when creating a new forum discussion should be visible by default

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forms Library
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Open up a forum activity (in Firefox / Chrome)
      Click to post a new message
      Confirm that message reads 'Maximum size for new files: XXMB, maximum attachments: 1'
      Confirm that the box reads 'No files attached - drag and drop files here to upload them'.
      Repeat with IE
      Confirm top message is the same and that the box simply reads 'No files attached'.

      Repeat instructions with a 'File' resource
      Confirm that the top message is simply 'Maximum size for new files XXMB' (no mention of 'maximum attachments')
      (You could also confirm the message in the box, although there is no reason for that to be different).

      Show
      Open up a forum activity (in Firefox / Chrome) Click to post a new message Confirm that message reads 'Maximum size for new files: XXMB, maximum attachments: 1' Confirm that the box reads 'No files attached - drag and drop files here to upload them'. Repeat with IE Confirm top message is the same and that the box simply reads 'No files attached'. Repeat instructions with a 'File' resource Confirm that the top message is simply 'Maximum size for new files XXMB' (no mention of 'maximum attachments') (You could also confirm the message in the box, although there is no reason for that to be different).
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-31642_dndupload_filemanager_notification_text
    • Rank:
      38212

      Description

      Currently when you create a new forum discussion the files area doesnt clearly indicate where to drop files you want to attach. "drop files here to upload" should be visible by default. And centred to. Having it disappear once the user has uploaded a single file makes sense but having it hidden until the user drags a file into the page makes little sense. We're telling them drag and drop is available but not telling them where until they've dragged in a file.

      On a related note, the string "drag and drop available" above the file area should be removed. Telling the user that drag and drop is available somewhere on the page is unnecessarily mysterious. It would be better if the file area told the user that they could drag files there and if the area immediately above it, instead of saying "Maximum size for new files: 2MB - drag and drop available", said "Maximum size for new files: 2MB Maximum attachments: 2"

        Issue Links

          Activity

          Hide
          Davo Smith added a comment -

          What about the situation where a filemanager already has some files attached - how do we inform the user that drag and drop is still available?

          Also, the text above the box used to read 'You can drag and drop files into this box to upload them' (see MDL-31153). The idea being that the 'mysterious' text has a help button beside it to explain what it means, if the user is unsure.

          Show
          Davo Smith added a comment - What about the situation where a filemanager already has some files attached - how do we inform the user that drag and drop is still available? Also, the text above the box used to read 'You can drag and drop files into this box to upload them' (see MDL-31153 ). The idea being that the 'mysterious' text has a help button beside it to explain what it means, if the user is unsure.
          Hide
          Michael de Raadt added a comment -

          Thanks for looking at this, Davo.

          Show
          Michael de Raadt added a comment - Thanks for looking at this, Davo.
          Hide
          Davo Smith added a comment -

          I've made the changes suggested:

          • added a 'max attachments' message
          • added the text 'drag and drop files here to upload them' inside the filemanager box (when there are no files currently uploaded)
          • updated the filepicker box to use this text as well

          I have not removed the 'drag and drop enabled' message on top of the box (despite it pushing the text onto two lines in some cases), as it would be nice to still have some sort of indication to users that drag and drop of files is available when they are editing a form which already has some files attached (either just uploaded, or uploaded on a previous session).

          Maybe we could replace all the text above the box with some friendly icons?
          A 'max size' icon + number, a 'max files' icon + number and a 'drag & drop icon', all with hover text?

          Show
          Davo Smith added a comment - I've made the changes suggested: added a 'max attachments' message added the text 'drag and drop files here to upload them' inside the filemanager box (when there are no files currently uploaded) updated the filepicker box to use this text as well I have not removed the 'drag and drop enabled' message on top of the box (despite it pushing the text onto two lines in some cases), as it would be nice to still have some sort of indication to users that drag and drop of files is available when they are editing a form which already has some files attached (either just uploaded, or uploaded on a previous session). Maybe we could replace all the text above the box with some friendly icons? A 'max size' icon + number, a 'max files' icon + number and a 'drag & drop icon', all with hover text?
          Hide
          Dan Poltawski added a comment -

          This mostly makes sense to me, however in lib/form/filemanager.php you are concatenating language strings. You'll need to create a new string doing both of these instead as concatenating strings like this will break right to left languages.

          Show
          Dan Poltawski added a comment - This mostly makes sense to me, however in lib/form/filemanager.php you are concatenating language strings. You'll need to create a new string doing both of these instead as concatenating strings like this will break right to left languages.
          Hide
          Davo Smith added a comment -

          @Dan - I've replaced the language string concatenation with a new language string.

          Please could you double-check this and put forward for integration if it is all OK?

          Show
          Davo Smith added a comment - @Dan - I've replaced the language string concatenation with a new language string. Please could you double-check this and put forward for integration if it is all OK?
          Hide
          Dan Poltawski added a comment -

          Whoops - Davo this needs testing instructions - could you add

          Show
          Dan Poltawski added a comment - Whoops - Davo this needs testing instructions - could you add
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Davo Smith added a comment -

          Rebase done (without conflicts)

          Show
          Davo Smith added a comment - Rebase done (without conflicts)
          Hide
          Sam Hemelryk added a comment -

          Thanks Davo, this has been integrated now.

          Looking at the filemanager code I see that there is more and more hooking into it now, certainly in the future we will have to come up with an event system for it!

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Davo, this has been integrated now. Looking at the filemanager code I see that there is more and more hooking into it now, certainly in the future we will have to come up with an event system for it! Cheers Sam
          Hide
          Andrew Davis added a comment -

          Works as described. Passing.

          Show
          Andrew Davis added a comment - Works as described. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

          icao_reverse('arreis olik rebemevon afla letoh ognat');
          

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: