Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31643

If the user drags and drops more files than the forum allows to be attached to a discussion some of them are accepted while others are rejected

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forms Library
    • Labels:

      Description

      Go into a forum and go to the screen used to create a new discussion.

      If the user drags in more files than than the maximum number of attachments (max attachments is in the forum settings) a random subset of files get attached. If I am a teacher and I have 2 documents (say, the exam location announcement and the practice exam) to distribute to my students but I'm only allowed 1 attachment its unlikely that I'll say "ah well, that'll have to do" when only 1 of those documents attach while the other vanishes. We're just forcing the user to then delete any files that did upload before starting over ie putting those files into a zip then uploading that or similar.

      We should either accept all of the files, or if we can't, then display an error and reject the whole lot.

        Gliffy Diagrams

          Issue Links

            Activity

            andyjdavis Andrew Davis created issue -
            andyjdavis Andrew Davis made changes -
            Field Original Value New Value
            Link This issue discovered while testing MDL-31114 [ MDL-31114 ]
            davosmith Davo Smith made changes -
            Assignee moodle.com [ moodle.com ] Davo Smith [ davosmith ]
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            Affects Version/s 2.2.1 [ 11456 ]
            Affects Version/s 2.3 [ 10657 ]
            salvetore Michael de Raadt made changes -
            Affects Version/s 2.3 [ 10657 ]
            Affects Version/s 2.2.1 [ 11456 ]
            davosmith Davo Smith made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Pull Master Diff URL https://github.com/davosmith/moodle/compare/master...MDL-31643_dndupload_reject_all_files
            Pull Master Branch MDL-31643_dndupload_reject_all_files
            Pull from Repository git://github.com/davosmith/moodle.git
            poltawski Dan Poltawski made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer poltawski
            poltawski Dan Poltawski made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            poltawski Dan Poltawski made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.3 [ 10657 ]
            Fix Version/s STABLE backlog [ 10463 ]
            samhemelryk Sam Hemelryk made changes -
            Environment # Create a new forum and limit the number of attachments to 2
            # Drag and drop 3 files into a forum post
            # Check that you get an error and no files get attached
            samhemelryk Sam Hemelryk made changes -
            Testing Instructions # Create a new forum and limit the number of attachments to 2
            # Drag and drop 3 files into a forum post
            # Check that you get an error and no files get attached
            Environment # Create a new forum and limit the number of attachments to 2
            # Drag and drop 3 files into a forum post
            # Check that you get an error and no files get attached
            salvetore Michael de Raadt made changes -
            Tester ankit_frenz
            ankit_frenz Ankit Agarwal made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            ankit_frenz Ankit Agarwal made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 09/Mar/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12