Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29160 META: en language pack improvements
  3. MDL-31651

The title of the course info page is hardcoded

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.1.4, 2.2.1
          • Fix Version/s: 2.1.5, 2.2.2
          • Component/s: Course
          • Labels:
          • Testing Instructions:
            Hide

            [simple cheating instructions]
            1/ Install the german lang pack
            2/ Visit http://moodle/course/info.php?id=3&?lang=de [where 3 is a valid course id]
            Expected result:

            • The title is in german
              Actual Result:
            • Title is hardcoded english

            [Advanced through instructions]

            • On the course/ page, select a categories with many courses (more than 10).
            • Click on the blue icon right next to any course
            • Select another language than english
            • The title won't change
            Show
            [simple cheating instructions] 1/ Install the german lang pack 2/ Visit http://moodle/course/info.php?id=3&?lang=de [where 3 is a valid course id] Expected result: The title is in german Actual Result: Title is hardcoded english [Advanced through instructions] On the course/ page, select a categories with many courses (more than 10). Click on the blue icon right next to any course Select another language than english The title won't change
          • Workaround:
            Hide

            Understanding English

            Show
            Understanding English
          • Affected Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Pull from Repository:

            Description

            The course info title is hard coded.

            To repair, simply replace this code at line 40:

            course/info.php

            		 
            $PAGE->set_heading('Course info');

            with:

            course/info.php

            		 
            $PAGE->set_heading(get_string('courseinfo'));

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  salvetore Michael de Raadt added a comment -

                  Thanks for reporting that and providing a fix.

                  Show
                  salvetore Michael de Raadt added a comment - Thanks for reporting that and providing a fix.
                  Hide
                  Permalink
                  leblangi Gilles-Philippe Leblanc added a comment -

                  No problem.

                  Show
                  leblangi Gilles-Philippe Leblanc added a comment - No problem.
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  Thanks for the report.

                  Integrators - this can be cherry picked to 21_STABLE and master

                  Show
                  poltawski Dan Poltawski added a comment - Thanks for the report. Integrators - this can be cherry picked to 21_STABLE and master
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                  TIA and ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                  Hide
                  Permalink
                  poltawski Dan Poltawski added a comment -

                  rebased

                  Show
                  poltawski Dan Poltawski added a comment - rebased
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Integrated, thanks! (21, 22 and master)

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 and master)
                  Hide
                  Permalink
                  andyjdavis Andrew Davis added a comment -

                  passing

                  Show
                  andyjdavis Andrew Davis added a comment - passing
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Well,

                  I wish I said it every time
                  you do the things you do.
                  You always lend a helping hand,
                  and I'm filled with gratitude.

                  You are strong and generous
                  for each and everyone one of us.
                  I am eternally grateful,
                  I cannot say thanks enough.

                  Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        12/Mar/12