Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      [simple cheating instructions]
      1/ Install the german lang pack
      2/ Visit http://moodle/course/info.php?id=3&?lang=de [where 3 is a valid course id]
      Expected result:

      • The title is in german
        Actual Result:
      • Title is hardcoded english

      [Advanced through instructions]

      • On the course/ page, select a categories with many courses (more than 10).
      • Click on the blue icon right next to any course
      • Select another language than english
      • The title won't change
      Show
      [simple cheating instructions] 1/ Install the german lang pack 2/ Visit http://moodle/course/info.php?id=3&?lang=de [where 3 is a valid course id] Expected result: The title is in german Actual Result: Title is hardcoded english [Advanced through instructions] On the course/ page, select a categories with many courses (more than 10). Click on the blue icon right next to any course Select another language than english The title won't change
    • Workaround:
      Hide

      Understanding English

      Show
      Understanding English
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Rank:
      38222

      Description

      The course info title is hard coded.

      To repair, simply replace this code at line 40:

      course/info.php
      $PAGE->set_heading('Course info');
      

      with:

      course/info.php
      $PAGE->set_heading(get_string('courseinfo'));
      

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting that and providing a fix.

        Show
        Michael de Raadt added a comment - Thanks for reporting that and providing a fix.
        Hide
        Gilles-Philippe Leblanc added a comment -

        No problem.

        Show
        Gilles-Philippe Leblanc added a comment - No problem.
        Hide
        Dan Poltawski added a comment -

        Thanks for the report.

        Integrators - this can be cherry picked to 21_STABLE and master

        Show
        Dan Poltawski added a comment - Thanks for the report. Integrators - this can be cherry picked to 21_STABLE and master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        rebased

        Show
        Dan Poltawski added a comment - rebased
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (21, 22 and master)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 and master)
        Hide
        Andrew Davis added a comment -

        passing

        Show
        Andrew Davis added a comment - passing
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Well,

        I wish I said it every time
        you do the things you do.
        You always lend a helping hand,
        and I'm filled with gratitude.

        You are strong and generous
        for each and everyone one of us.
        I am eternally grateful,
        I cannot say thanks enough.

        Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: