Moodle
  1. Moodle
  2. MDL-31652

SCORM updatefreq setting shouldn't allow use when only uploaded files being used

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      In Admin > plugins > activity modules > SCORM
      make sure the following items are disabled:
      allowtypeexternal
      allowtypelocalsync
      allowtypeimsrepository
      allowtypeexternalaicc

      Then go to a course and create a New SCORM and check the settings to make sure the updatefreq setting doesn't appear (make sure you hit the show advanced setting)

      Now go back to:
      In Admin > plugins > activity modules > SCORM
      enable some of the settings you checked before:
      allowtypeexternal
      allowtypelocalsync
      allowtypeimsrepository
      allowtypeexternalaicc

      Then go to a course and create a new SCORM and check the settings to make sure the updatefreq setting appears now and is disabled when the "type" selector (appears above the filepicker) is set to "uploaded package" but if any other type is selected it is enabled.

      also check to make sure the old item "onchanges" option in the updatefreq list no longer appears.

      Show
      In Admin > plugins > activity modules > SCORM make sure the following items are disabled: allowtypeexternal allowtypelocalsync allowtypeimsrepository allowtypeexternalaicc Then go to a course and create a New SCORM and check the settings to make sure the updatefreq setting doesn't appear (make sure you hit the show advanced setting) Now go back to: In Admin > plugins > activity modules > SCORM enable some of the settings you checked before: allowtypeexternal allowtypelocalsync allowtypeimsrepository allowtypeexternalaicc Then go to a course and create a new SCORM and check the settings to make sure the updatefreq setting appears now and is disabled when the "type" selector (appears above the filepicker) is set to "uploaded package" but if any other type is selected it is enabled. also check to make sure the old item "onchanges" option in the updatefreq list no longer appears.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-31652
    • Rank:
      38223

      Description

      SCORM has a setting that allows the package in Moodle to be updated based on an external file - so if SCORM links to a zip hosted outside Moodle or a manifest file stored somewhere else the teacher can modify that content and have it automatically updated in Moodle.

      But - this setting still shows (and performs unnecessary work) when a teacher uploads a scorm - we should hide the setting completely if external options aren't enabled and we should disable the field if others are enabled and user uploads normally.

      We should also update the help strings/docs.

        Issue Links

          Activity

          Dan Marsden created issue -
          Dan Marsden made changes -
          Field Original Value New Value
          Fix Version/s STABLE backlog [ 10463 ]
          Labels triaged
          Dan Marsden made changes -
          Link This issue has a non-specific relationship to MDL-31611 [ MDL-31611 ]
          Dan Marsden made changes -
          Testing Instructions In Admin > plugins > activity modules > SCORM
          make sure the following items are disabled:
          allowtypeexternal
          allowtypelocalsync
          allowtypeimsrepository
          allowtypeexternalaicc

          Then go to a course and create a New SCORM and check the settings to make sure the updatefreq setting doesn't appear (make sure you hit the show advanced setting)

          Now go back to:
          In Admin > plugins > activity modules > SCORM
          enable some of the settings you checked before:
          allowtypeexternal
          allowtypelocalsync
          allowtypeimsrepository
          allowtypeexternalaicc

          Then go to a course and create a new SCORM and check the settings to make sure the updatefreq setting appears now and is disabled when the "type" selector (appears above the filepicker) is set to "uploaded package" but if any other type is selected it is enabled.
          Dan Marsden made changes -
          Pull Master Diff URL https://github.com/danmarsden/moodle/compare/master...master_MDL-31652
          Pull Master Branch master_MDL-31652
          Testing Instructions In Admin > plugins > activity modules > SCORM
          make sure the following items are disabled:
          allowtypeexternal
          allowtypelocalsync
          allowtypeimsrepository
          allowtypeexternalaicc

          Then go to a course and create a New SCORM and check the settings to make sure the updatefreq setting doesn't appear (make sure you hit the show advanced setting)

          Now go back to:
          In Admin > plugins > activity modules > SCORM
          enable some of the settings you checked before:
          allowtypeexternal
          allowtypelocalsync
          allowtypeimsrepository
          allowtypeexternalaicc

          Then go to a course and create a new SCORM and check the settings to make sure the updatefreq setting appears now and is disabled when the "type" selector (appears above the filepicker) is set to "uploaded package" but if any other type is selected it is enabled.
          In Admin > plugins > activity modules > SCORM
          make sure the following items are disabled:
          allowtypeexternal
          allowtypelocalsync
          allowtypeimsrepository
          allowtypeexternalaicc

          Then go to a course and create a New SCORM and check the settings to make sure the updatefreq setting doesn't appear (make sure you hit the show advanced setting)

          Now go back to:
          In Admin > plugins > activity modules > SCORM
          enable some of the settings you checked before:
          allowtypeexternal
          allowtypelocalsync
          allowtypeimsrepository
          allowtypeexternalaicc

          Then go to a course and create a new SCORM and check the settings to make sure the updatefreq setting appears now and is disabled when the "type" selector (appears above the filepicker) is set to "uploaded package" but if any other type is selected it is enabled.

          also check to make sure the old item "onchanges" option in the updatefreq list no longer appears.
          Pull from Repository git://github.com/danmarsden/moodle.git
          Dan Marsden made changes -
          Dan Marsden made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull 2.1 Branch m21_MDL-31652
          Pull 2.1 Diff URL https://github.com/danmarsden/moodle/compare/MOODLE_21_STABLE...m21_MDL-31652
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Michael de Raadt made changes -
          Tester rwijaya
          Rossiani Wijaya made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Rossiani Wijaya made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Eloy Lafuente (stronk7) made changes -
          Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.1 [ 10370 ]
          Rossiani Wijaya made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Rossiani Wijaya made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 23/Feb/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: