Moodle

No warning after editing textbox and not saving.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.3
  • Component/s: Forms Library
  • Labels:
  • Testing Instructions:
    Hide

    Note to tester: This change is related to MDL-31655 and MDL-31660. To aid your testing, you may want to test all three together. These instructions are additive

    Log in to Moodle and navigate to a course

    • Choose Edit Settings
    Without any changes
    • Refresh the page (the page refreshes)
    • Hit the back button (you go back in time and space)
    • Go back to the Edit Settings Page
    • Try closing the browser window (it closes)
    • Reopen, Click Save and Display (the form saves)
    Now make some changes to various fields
    • Go back to the Edit Settings Page
    • Make a change to the 'Course full name' - do not move off the field
    • Refresh the page (you get a popup) - click to stay
    • Hit the back button (you get a popup) - click to stay
    • Try closing the browser window/tab (you get a popup) - click to stay
    • Click Save and Display (the form saves)
    Show
    Note to tester: This change is related to MDL-31655 and MDL-31660 . To aid your testing, you may want to test all three together. These instructions are additive Log in to Moodle and navigate to a course Choose Edit Settings Without any changes Refresh the page (the page refreshes) Hit the back button (you go back in time and space) Go back to the Edit Settings Page Try closing the browser window (it closes) Reopen, Click Save and Display (the form saves) Now make some changes to various fields Go back to the Edit Settings Page Make a change to the 'Course full name' - do not move off the field Refresh the page (you get a popup) - click to stay Hit the back button (you get a popup) - click to stay Try closing the browser window/tab (you get a popup) - click to stay Click Save and Display (the form saves)
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-31655-master-3
  • Pull Master Diff URL:

Description

Editing a text box in a form and then immediatly refreshing / pressing the back button / closing the window without losing focus from the text box will not trigger a dialogue box asking if you want to save changes made to the form.

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31315 Warn users before moving away from modified forms

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
has a non-specific relationship to

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31740 Store form change state in a different js variable

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
is blocked by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31660 Rename and tidy up lib/yui/formslib/formslib.js

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting that, Adrian.

Andrew: I'm assigning this to you because you worked on the related issue, but if you would rather not work on this, please reassign it to moodle.com.

Show
Michael de Raadt added a comment - Thanks for reporting that, Adrian. Andrew: I'm assigning this to you because you worked on the related issue, but if you would rather not work on this, please reassign it to moodle.com.
Hide
Permalink
Andrew Nicols added a comment -

I've got a solution in the pipeline for this, but I'm waiting for this week's integration to be released so that I can base it on that.

Show
Andrew Nicols added a comment - I've got a solution in the pipeline for this, but I'm waiting for this week's integration to be released so that I can base it on that.
Hide
Permalink
Andrew Nicols added a comment -

I've based this change on MDL-31673 as this seemed the safest option. Hopefully you agree!

Show
Andrew Nicols added a comment - I've based this change on MDL-31673 as this seemed the safest option. Hopefully you agree!
Hide
Permalink
Andrew Nicols added a comment -

This patchset probably all want testing together to save the tester some sanity:

Show
Andrew Nicols added a comment - This patchset probably all want testing together to save the tester some sanity: MDL-31655 MDL-31656 MDL-31673
Hide
Permalink
Dan Poltawski added a comment -

Looks good to me, took me a bit to understand what was going on and that the 'on blur' event is when an element looses focus and the problem here is that the element isn't loosing focus.

One question unrelated to this change but instead about this feature - we are storing things in 'M.cfg' but I am sure they do not get put back into the config table? Is this the correct place to store such things? What happens if someone reuses the name for a proper config option.

Show
Dan Poltawski added a comment - Looks good to me, took me a bit to understand what was going on and that the 'on blur' event is when an element looses focus and the problem here is that the element isn't loosing focus. One question unrelated to this change but instead about this feature - we are storing things in 'M.cfg' but I am sure they do not get put back into the config table? Is this the correct place to store such things? What happens if someone reuses the name for a proper config option.
Hide
Permalink
Andrew Nicols added a comment -

Good question - perhaps we should create a new location for state storage data...

Show
Andrew Nicols added a comment - Good question - perhaps we should create a new location for state storage data...
Hide
Permalink
Andrew Nicols added a comment -

The content of this change hasn't differed greatly - just renamed the variables and functions to fit into the changes made in MDL-31660.

Waiting for MDL-31660 to go through peer review and will submit this for Integration Review at the same time as MDL-31660 and MDL-31740

Show
Andrew Nicols added a comment - The content of this change hasn't differed greatly - just renamed the variables and functions to fit into the changes made in MDL-31660 . Waiting for MDL-31660 to go through peer review and will submit this for Integration Review at the same time as MDL-31660 and MDL-31740
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Andrew Nicols added a comment -

Rebases cleanly onto latest master

Show
Andrew Nicols added a comment - Rebases cleanly onto latest master
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Andrew this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Andrew this has been integrated now
Hide
Permalink
Andrew Davis added a comment -

Works as described. Passing.

Show
Andrew Davis added a comment - Works as described. Passing.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

icao_reverse('arreis olik rebemevon afla letoh ognat');

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: