Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.3
-
MOODLE_23_STABLE
-
MOODLE_23_STABLE
-
MDL-31656-master-3 -
Note to tester: This change is related to
MDL-31660andMDL-31655. To aid your testing, you may want to test all three together. These instructions are additive
Uploading and Downloading a file
- In a form with a file picker (new discussion for example)
- Upload a file using the 'Add' button and the filepicker
- Refresh the page (you get a popup) - click to stay
- Hit the back button (you get a popup) - click to stay
- Try closing the browser window/tab (you get a popup) - click to stay
- From the menu on the file, choose Download
- Confirm that the file downloads
- Confirm that no warning was given
Note to tester: This change is related to MDL-31660 and MDL-31655 . To aid your testing, you may want to test all three together. These instructions are additive Uploading and Downloading a file In a form with a file picker (new discussion for example) Upload a file using the 'Add' button and the filepicker Refresh the page (you get a popup) - click to stay Hit the back button (you get a popup) - click to stay Try closing the browser window/tab (you get a popup) - click to stay From the menu on the file, choose Download Confirm that the file downloads Confirm that no warning was given
Description
While testing MDL-31114 with MDL-31315 patch in integration.git, i noticed that after i uploaded a file to a form and if i then (just to be a bandwidth hog) tried to download it again, i would be prompted to stay or leave the page.
If i chose 'stay' i wouldn't get any download happening. If i chose 'leave' the file would get downloaded.
I think primarily that having the download option in files just uploaded is slightly ridiculous but i understand it is a valid option to have.
Still, if we have the download option, i think it shouldn't be triggering the 'form has changed' warning prompts.
Attachments
Issue Links
- Discovered while testing
-
-
- Closed
-