Moodle
  1. Moodle
  2. MDL-31666

moodle.git does not contain all CVS commits, stable branches and and tags

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      1. Make sure that the repository contains new MOODLE_13_STABLE, MOODLE_14_STABLE and MOODLE_15_STABLE branches
      2. Make sure that the repository contains tags for all historical Moodle releases described at http://docs.moodle.org/dev/Releases (note that the tag date may be different from the one at the page)
      3 Let Git show each of these new tags and make sure that:
      3.1 The tag name has the form vX.Y.Z
      3.2 The tag message has the form MOODLE_XY or MOODLE_XYZ
      3.3 The tag date is the same as the tagged commit's date (it was important to set these dates into the past so versions appear at correct chronological order at the web)
      3.4 The tag actually tags a reasonable commit (I generally chose commits that modify the $release variable in version.php unless there was a good reason to break this rule)

      You can find the following Linux command useful when testing the point 3:

      1. for TAG in $(git tag -l | grep v1.[0-8].) ; do git show $TAG; done
      Show
      1. Make sure that the repository contains new MOODLE_13_STABLE, MOODLE_14_STABLE and MOODLE_15_STABLE branches 2. Make sure that the repository contains tags for all historical Moodle releases described at http://docs.moodle.org/dev/Releases (note that the tag date may be different from the one at the page) 3 Let Git show each of these new tags and make sure that: 3.1 The tag name has the form vX.Y.Z 3.2 The tag message has the form MOODLE_XY or MOODLE_XYZ 3.3 The tag date is the same as the tagged commit's date (it was important to set these dates into the past so versions appear at correct chronological order at the web) 3.4 The tag actually tags a reasonable commit (I generally chose commits that modify the $release variable in version.php unless there was a good reason to break this rule) You can find the following Linux command useful when testing the point 3: for TAG in $(git tag -l | grep v1. [0-8] .) ; do git show $TAG; done
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Rank:
      38240

      Description

      While working on the new local_dev plugin, I realized that the current moodle.git does not contain all commits from CVS. The reason for this was that we kept just refs/heads/MOODLE_16_STABLE and higher. So all commits that led to MOODLE_13_STABLE, MOODLE_14_STABLE and MOODLE_15_STABLE were pruned by Git garbage collector. Therefore there was no way to re-tag legacy releases (which is what I need for local_dev).

      Luckily there is still Catalyst's moodle-r2.git available so I was able to fetch missing commits and add them to my clone of moodle.git. I think it would be nice to have upstream moodle.git complete so I'm submitting this to upstream.

      To get missing branches, commits and tags to integration.git, integrators may want to do something like this:

      1. git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_13_STABLE:MOODLE_13_STABLE
      2. git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_14_STABLE:MOODLE_14_STABLE
      3. git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_15_STABLE:MOODLE_15_STABLE

      When testing passes, just push the new branches and tags to moodle.git

      See the testing instructions for how I think this could be double-checked.

        Issue Links

          Activity

          David Mudrak created issue -
          David Mudrak made changes -
          Field Original Value New Value
          Assignee Rajesh Taneja [ rajeshtaneja ] David Mudrak [ mudrd8mz ]
          David Mudrak made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull from Repository git://github.com/mudrd8mz/moodle.git
          Fix Version/s 2.2.2 [ 11552 ]
          Michael de Raadt made changes -
          Labels triaged
          David Mudrak made changes -
          Description While working on the new local_dev plugin, I realized that the current moodle.git does not contain all commits from CVS. The reason for this was that we kept just refs/heads/MOODLE_16_STABLE and higher. So all commits that led to MOODLE_13_STABLE, MOODLE_14_STABLE and MOODLE_15_STABLE were pruned by Git garbage collector. Therefore there was no way to re-tag legacy releases (which is what I need for local_dev).

          Luckily there is still Catalyst's moodle-r2.git available so I was able to fetch missing commits and add them to my clone of moodle.git. I think it would be nice to have upstream moodle.git complete so I'm submitting this to upstream.

          To get missing branches, commits and tags to integration.git, integrators may want to do something like (not testing, please think twice before you press Enter ;-))

          # git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_13_STABLE
          # git checkout -b MOODLE_13_STABLE FETCH_HEAD

          Repeat for 1.4 and 1.5 stable branches.

          When testing passes, just push the new branches and tags to moodle.git

          See the testing instructions for how I think this could be double-checked.
          While working on the new local_dev plugin, I realized that the current moodle.git does not contain all commits from CVS. The reason for this was that we kept just refs/heads/MOODLE_16_STABLE and higher. So all commits that led to MOODLE_13_STABLE, MOODLE_14_STABLE and MOODLE_15_STABLE were pruned by Git garbage collector. Therefore there was no way to re-tag legacy releases (which is what I need for local_dev).

          Luckily there is still Catalyst's moodle-r2.git available so I was able to fetch missing commits and add them to my clone of moodle.git. I think it would be nice to have upstream moodle.git complete so I'm submitting this to upstream.

          To get missing branches, commits and tags to integration.git, integrators may want to do something like this:

          # git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_13_STABLE:MOODLE_13_STABLE
          # git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_14_STABLE:MOODLE_14_STABLE
          # git fetch --tags git://github.com/mudrd8mz/moodle.git MOODLE_15_STABLE:MOODLE_15_STABLE

          When testing passes, just push the new branches and tags to moodle.git

          See the testing instructions for how I think this could be double-checked.
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.3 [ 10657 ]
          Affects Version/s 2.2.1 [ 11456 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester stronk7
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          David Mudrak made changes -
          Link This issue blocks MDLSITE-1663 [ MDLSITE-1663 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 23/Feb/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: