Moodle
  1. Moodle
  2. MDL-31676

error in lib/formslib.php v1.129.2.29

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.16
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      38250

      Description

      there is a call to a function not implemented in php 4.3 (wich is required for moodle 1.9).
      In line 1504:
      } else if (method_exists($element, 'getPrivateName') && !($element instanceof HTML_QuickForm_advcheckbox)) {

      The function instanceof is implemented in php 5. This call should be replaced by is_a()

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for suggesting that, Leo.

        Unfortunately this won't be fixed in core Moodle for two reasons: 1. The current minimum PHP requirement for Moodle is greater than PHP 5. 2. Moodle 1.9 is not longer supported, except for serious security issues.

        I'll leave this issue here, with your solution, in case anyone else has the same problem.

        Show
        Michael de Raadt added a comment - Thanks for suggesting that, Leo. Unfortunately this won't be fixed in core Moodle for two reasons: 1. The current minimum PHP requirement for Moodle is greater than PHP 5. 2. Moodle 1.9 is not longer supported, except for serious security issues. I'll leave this issue here, with your solution, in case anyone else has the same problem.
        Hide
        Leo Borioni added a comment -

        That's partially true, Michael. For two reasons:

        1 - Moodle 1.9.16 requires php 4.3.0 as it's explicitly specified in the main download page (http://download.moodle.org).
        2 - The bug was introduced as a result of a serious security issue fix. It wasn't there before. Wrong fix, must be repaired.

        Afterall, if we are offering a stable moodle version stating that it works with php 4.3.0 we can't include code not supported by that php version.

        Show
        Leo Borioni added a comment - That's partially true, Michael. For two reasons: 1 - Moodle 1.9.16 requires php 4.3.0 as it's explicitly specified in the main download page ( http://download.moodle.org ). 2 - The bug was introduced as a result of a serious security issue fix. It wasn't there before. Wrong fix, must be repaired. Afterall, if we are offering a stable moodle version stating that it works with php 4.3.0 we can't include code not supported by that php version.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: