Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31679

Add a horizontal scroll bar to the top of the gradebook Grader Report

    Details

    • Testing Instructions:
      Hide

      Go to any Moodle gradebook and select the Grader Report. If there are several gradebook items, the instructor will have to scroll to the right to view all the items in the gradebook.

      If this is working correctly, a scrollbar should be visible at the top of the grade book as well as at the bottom.

      The scrollbar at the top should match the one at the bottom and moving either one should have the other move in sync with it.

      Needs to be tested with both $CFG->grade_report_fixedstudents enabled and disabled as this option changes how the gradebook is rendered.

      Show
      Go to any Moodle gradebook and select the Grader Report. If there are several gradebook items, the instructor will have to scroll to the right to view all the items in the gradebook. If this is working correctly, a scrollbar should be visible at the top of the grade book as well as at the bottom. The scrollbar at the top should match the one at the bottom and moving either one should have the other move in sync with it. Needs to be tested with both $CFG->grade_report_fixedstudents enabled and disabled as this option changes how the gradebook is rendered.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      A client site administrator would like to have a horizontal scroll bar added to the top of the gradebook Grader Report view. This is in addition to the scroll bar currently available at the bottom of the Grader Report.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for suggesting that.

              That sounds like it could be useful, but I'm not sure it's possible.

              Show
              salvetore Michael de Raadt added a comment - Thanks for suggesting that. That sounds like it could be useful, but I'm not sure it's possible.
              Hide
              vfrohne Vickie Frohne added a comment - - edited

              The fix suggested in MDL-25788 (anchor to the scroll bar to the bottom of the screen) would be another option. It is inconvenient to scroll down all the way to the bottom of the list of students every time one wishes to navigate left and right in the Grader Report view, especially with a large class. One could view only a few students at a time, but this makes it unacceptably slow to type in the grades.

              It would also be nice to keep the column names visible at the top of the screen while scrolling up and down. MDL-21748

              Show
              vfrohne Vickie Frohne added a comment - - edited The fix suggested in MDL-25788 (anchor to the scroll bar to the bottom of the screen) would be another option. It is inconvenient to scroll down all the way to the bottom of the list of students every time one wishes to navigate left and right in the Grader Report view, especially with a large class. One could view only a few students at a time, but this makes it unacceptably slow to type in the grades. It would also be nice to keep the column names visible at the top of the screen while scrolling up and down. MDL-21748
              Hide
              katpot Katarzyna Potocka added a comment -

              that would be also something that our users requested.
              In addition it probably would be very useful to have the alphabetic sorting possibility for first name and name to have a better overview of all students.

              Show
              katpot Katarzyna Potocka added a comment - that would be also something that our users requested. In addition it probably would be very useful to have the alphabetic sorting possibility for first name and name to have a better overview of all students.
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Implementing something like this: http://www.matts411.com/post/grid/
              Could be nice

              Show
              nadavkav Nadav Kavalerchik added a comment - Implementing something like this: http://www.matts411.com/post/grid/ Could be nice
              Hide
              nadavkav Nadav Kavalerchik added a comment -
              Show
              nadavkav Nadav Kavalerchik added a comment - Seems to solve this issue: https://github.com/CLAMP-IT/moodle-report_laegrader
              Hide
              andyjdavis Andrew Davis added a comment -

              This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

              For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

              Show
              andyjdavis Andrew Davis added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
              Hide
              nadavkav Nadav Kavalerchik added a comment -

              Workaround:
              (1) When using Chrome, use the SHIFT key on the keyboard along with the mouse middle button "scroller" to scroll left/right (horizontally)
              (2) When using Firefox, click and hold the middle "scroller" button of the mouse to scroll left/right (horizontally)

              Show
              nadavkav Nadav Kavalerchik added a comment - Workaround: (1) When using Chrome, use the SHIFT key on the keyboard along with the mouse middle button "scroller" to scroll left/right (horizontally) (2) When using Firefox, click and hold the middle "scroller" button of the mouse to scroll left/right (horizontally)
              Hide
              aolley Adam Olley added a comment -

              Linked branch includes a yui module that's included in the grader report that adds a scrollbar to the top of the grader report.

              Show
              aolley Adam Olley added a comment - Linked branch includes a yui module that's included in the grader report that adds a scrollbar to the top of the grader report.
              Hide
              cibot CiBoT added a comment -

              Results for MDL-31679

              • Remote repository: git://github.com/aolley/moodle.git
              Show
              cibot CiBoT added a comment - Results for MDL-31679 Remote repository: git://github.com/aolley/moodle.git Remote branch MDL-31679 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2351 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2351/artifact/work/smurf.html
              Hide
              dobedobedoh Andrew Nicols added a comment -

              I'll leave this for Andrew Davis to review properly as gradebook maintainer - he may have additional thoughts on the concept of this within the gradebook itself.

              Just some observations on the JavaScript:

              1. Line 29 - invalid YUIDoc Docblock. Either remove the second *, or make the docblock comply with http://yui.github.io/yuidoc/syntax/index.html
              2. SELECTORS should be a static variable defined outside of M.gradereport_grader
              3. 36 - Incorrect whitespace on container assignment (see http://docs.moodle.org/dev/Javascript/Coding_style#Assignment)
              4. 38-40 The docblock for init does not contain the method name (see http://yui.github.io/yuidoc/syntax/index.html for further reference)
              5. 44: No log level, or component specified to Y.log
              6. 50-53 - The logic is confusing and hard to follow. Something more like the following would make it more understandable:

                var src = Y.one(SELECTORS.STATIC);
                if (!src) {
                    src = this.container;
                }

                This has the advantage that all subsequent calls to Y.one(src) would just become src

              7. 61: No need for var _this = this; The third argument to Y.on is the context (this), but if you take the SELECTORS out of the object, you won't need that anyway as they'll be a function-level variable in the module.

              And one comment on the change to the styles.css - why are you using !important? We try and avoid this wherever possible.

              Show
              dobedobedoh Andrew Nicols added a comment - I'll leave this for Andrew Davis to review properly as gradebook maintainer - he may have additional thoughts on the concept of this within the gradebook itself. Just some observations on the JavaScript: Line 29 - invalid YUIDoc Docblock. Either remove the second *, or make the docblock comply with http://yui.github.io/yuidoc/syntax/index.html SELECTORS should be a static variable defined outside of M.gradereport_grader 36 - Incorrect whitespace on container assignment (see http://docs.moodle.org/dev/Javascript/Coding_style#Assignment ) 38-40 The docblock for init does not contain the method name (see http://yui.github.io/yuidoc/syntax/index.html for further reference) 44: No log level, or component specified to Y.log 50-53 - The logic is confusing and hard to follow. Something more like the following would make it more understandable: var src = Y.one(SELECTORS.STATIC); if (!src) { src = this.container; } This has the advantage that all subsequent calls to Y.one(src) would just become src 61: No need for var _this = this; The third argument to Y.on is the context (this), but if you take the SELECTORS out of the object, you won't need that anyway as they'll be a function-level variable in the module. And one comment on the change to the styles.css - why are you using !important? We try and avoid this wherever possible.
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Oh, and line 55 - Y.one(src).insert will return the Node representing src, not the node representing topscroll, so 67-69 and 71-73 to the same thing at present.

              Show
              dobedobedoh Andrew Nicols added a comment - Oh, and line 55 - Y.one(src).insert will return the Node representing src, not the node representing topscroll, so 67-69 and 71-73 to the same thing at present.
              Hide
              aolley Adam Olley added a comment -

              Awesome feedback Andrew, thanks

              I'll try to get an updated commit pushed up sometime soon.

              Show
              aolley Adam Olley added a comment - Awesome feedback Andrew, thanks I'll try to get an updated commit pushed up sometime soon.
              Hide
              aolley Adam Olley added a comment -

              Addressed all of Andrew Nicols points.

              Although for #2 I just removed the comment altogether. A comment of "selectors" for a variable called "selectors" is a bit pointless.

              Also rebased ontop of latest master.

              Show
              aolley Adam Olley added a comment - Addressed all of Andrew Nicols points. Although for #2 I just removed the comment altogether. A comment of "selectors" for a variable called "selectors" is a bit pointless. Also rebased ontop of latest master.
              Hide
              cibot CiBoT added a comment -

              Results for MDL-31679

              • Remote repository: git://github.com/aolley/moodle.git
              Show
              cibot CiBoT added a comment - Results for MDL-31679 Remote repository: git://github.com/aolley/moodle.git Remote branch MDL-31679 to be integrated into upstream master Executed job http://social.srv.in.moodle.com/job/Precheck%20remote%20branch/2483 Details: http://social.srv.in.moodle.com/job/Precheck%20remote%20branch/2483/artifact/work/smurf.html
              Hide
              poltawski Dan Poltawski added a comment -

              Sending all 'waiting for peer review' issues for integration review. The integration team are doing this to ensure any 'integratable issues' will not got missed for freeze.

              Note: We will prioritise peer reviewed issues and may not spend as much time examining non-integratable, non peer-reviewed issues.

              This is a present from the iTeam - it means that peer review is not working well enough! We really do not want to do this again! Lets improve our peer review process!

              Show
              poltawski Dan Poltawski added a comment - Sending all 'waiting for peer review' issues for integration review. The integration team are doing this to ensure any 'integratable issues' will not got missed for freeze. Note: We will prioritise peer reviewed issues and may not spend as much time examining non-integratable, non peer-reviewed issues. This is a present from the iTeam - it means that peer review is not working well enough! We really do not want to do this again! Lets improve our peer review process!
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks a lot for this Adam - i've integrated it to master.

              Show
              poltawski Dan Poltawski added a comment - Thanks a lot for this Adam - i've integrated it to master.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              This passes as per the testing instructions. However this doesn't seem very intutive when keyboard navigation is considered.
              When you tab through the top scroll bar, the whole area below is selected next, i.e the bottom scrollbar and all activities being reported.

              Show
              ankit_frenz Ankit Agarwal added a comment - This passes as per the testing instructions. However this doesn't seem very intutive when keyboard navigation is considered. When you tab through the top scroll bar, the whole area below is selected next, i.e the bottom scrollbar and all activities being reported.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Reported MDL-45015 for the issue that I found.

              Passing the current issue.

              Show
              ankit_frenz Ankit Agarwal added a comment - Reported MDL-45015 for the issue that I found. Passing the current issue.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for your efforts, this change is now part of Moodle!

              Show
              poltawski Dan Poltawski added a comment - Thanks for your efforts, this change is now part of Moodle!
              Hide
              marycooch Mary Cooch added a comment -

              Removing docs_required as this is documented here (and much appreciated!) http://docs.moodle.org/27/en/Gradebook#Horizontal_scrollbar -please check and amend if necessary.

              Show
              marycooch Mary Cooch added a comment - Removing docs_required as this is documented here (and much appreciated!) http://docs.moodle.org/27/en/Gradebook#Horizontal_scrollbar -please check and amend if necessary.

                People

                • Votes:
                  13 Vote for this issue
                  Watchers:
                  15 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14