Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.7, 2.1.4, 2.2.1, 2.3
-
Component/s: Libraries
-
Labels:None
-
Testing Instructions:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
Although it's installed by default since PHP 5.1, so 99% of sites out there will have it... I think it's ok to check for it in environmental checks.
Right now we are using it in a few (non-super-critical) places... but with MDL-30698, it will be used by forums... so better check for it @ 2.3.
Ciao 
Gliffy Diagrams
Attachments
Issue Links
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Thanks Eloy
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
MAMP and XAMPP moodle distribution should be updated accordingly
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
Rebased, self-thanks!
Daniele, are you saying that MAMP or XAMPP base builds does not include that?
Hi Eloy,
Just before this gets integrated I wanted to check something.
I couldn't spot another self closing PHP_EXTENSION tag so it looks like this is a new way to write it. Knowing 100% that is it fine do we care?
Cheers
Sam
Actually sorry there is one <PHP_EXTENSION name="mbstring" level="optional" /> but still worth checking I suppose
Yeah, just when I was editing the file y saw all the other "silly" open/close pairs and initially was tempted to continue the "silliness". But, finally decided to go to the proper way, as far as those elements are not going to have sub-information, I think it's better XML practice to "autoclose" them.
Surely we can modify all the rest (although it's not critical at all), I just didn't want to add "noise" to this issue.
Ciao
Awesome Eloy, I completely agree if we can auto close we should be!
I've integrated this now and I suppose its just a case of making that change as some point, although hardly worth worrying about.
Cheers
Sam
Hi Guys,
This works as expected.
Passing this issue.
Thanks
Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).
icao_reverse('arreis olik rebemevon afla letoh ognat');
|
Closing, ciao
While surely we could have added this as one requirement to stable releases (21, 22) because there are some uses already... that would lead to some site stopping to work suddenly, so I've added the environmental check only for 2.3 versions.
Sending to integration...ciao