Moodle

Add environmental check to 2.3 about the hash extension installed.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.7, 2.1.4, 2.2.1, 2.3
  • Fix Version/s: 2.1.5, 2.2.2
  • Component/s: Libraries
  • Labels:
    None
  • Testing Instructions:
    Hide
    • Go to admin -> server -> environement
    • In the "Moodle version" dropdown menu pick 2.3 (note it's the unique value in master right now, but both 2.1 and 2.2 show other versions).
    • Verify that one line with "php_extension hash must be installed and enabled" is shown.
    • If you can pick other versions different from 2.3 in the drop-down menu (only in 21 and 22 stable), do it.
    • Verify other versions do not show the "php extension hash" requirement.
    Show
    Go to admin -> server -> environement In the "Moodle version" dropdown menu pick 2.3 (note it's the unique value in master right now, but both 2.1 and 2.2 show other versions). Verify that one line with "php_extension hash must be installed and enabled" is shown. If you can pick other versions different from 2.3 in the drop-down menu (only in 21 and 22 stable), do it. Verify other versions do not show the "php extension hash" requirement.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

Although it's installed by default since PHP 5.1, so 99% of sites out there will have it... I think it's ok to check for it in environmental checks.

Right now we are using it in a few (non-super-critical) places... but with MDL-30698, it will be used by forums... so better check for it @ 2.3.

Ciao

Issue Links

has been marked as being related by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32000 RADIUS authentification

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
is a QA test written for

Improvement - An enhancement to an existing Moodle feature. MDL-30698 Message-ID causes mail problem when sending to more than one person (e.g. forum subscription)

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

While surely we could have added this as one requirement to stable releases (21, 22) because there are some uses already... that would lead to some site stopping to work suddenly, so I've added the environmental check only for 2.3 versions.

Sending to integration...ciao

Show
Eloy Lafuente (stronk7) added a comment - While surely we could have added this as one requirement to stable releases (21, 22) because there are some uses already... that would lead to some site stopping to work suddenly, so I've added the environmental check only for 2.3 versions. Sending to integration...ciao
Hide
Permalink
Andrew Davis added a comment -

Thanks Eloy

Show
Andrew Davis added a comment - Thanks Eloy
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Daniele Cordella added a comment -

MAMP and XAMPP moodle distribution should be updated accordingly

Show
Daniele Cordella added a comment - MAMP and XAMPP moodle distribution should be updated accordingly
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Rebased, self-thanks!

Show
Eloy Lafuente (stronk7) added a comment - Rebased, self-thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Daniele, are you saying that MAMP or XAMPP base builds does not include that?

Show
Eloy Lafuente (stronk7) added a comment - Daniele, are you saying that MAMP or XAMPP base builds does not include that?
Hide
Permalink
Sam Hemelryk added a comment -

Hi Eloy,

Just before this gets integrated I wanted to check something.
I couldn't spot another self closing PHP_EXTENSION tag so it looks like this is a new way to write it. Knowing 100% that is it fine do we care?

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Eloy, Just before this gets integrated I wanted to check something. I couldn't spot another self closing PHP_EXTENSION tag so it looks like this is a new way to write it. Knowing 100% that is it fine do we care? Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Actually sorry there is one <PHP_EXTENSION name="mbstring" level="optional" /> but still worth checking I suppose

Show
Sam Hemelryk added a comment - Actually sorry there is one <PHP_EXTENSION name="mbstring" level="optional" /> but still worth checking I suppose
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yeah, just when I was editing the file y saw all the other "silly" open/close pairs and initially was tempted to continue the "silliness". But, finally decided to go to the proper way, as far as those elements are not going to have sub-information, I think it's better XML practice to "autoclose" them.

Surely we can modify all the rest (although it's not critical at all), I just didn't want to add "noise" to this issue.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Yeah, just when I was editing the file y saw all the other "silly" open/close pairs and initially was tempted to continue the "silliness". But, finally decided to go to the proper way, as far as those elements are not going to have sub-information, I think it's better XML practice to "autoclose" them. Surely we can modify all the rest (although it's not critical at all), I just didn't want to add "noise" to this issue. Ciao
Hide
Permalink
Sam Hemelryk added a comment -

Awesome Eloy, I completely agree if we can auto close we should be!
I've integrated this now and I suppose its just a case of making that change as some point, although hardly worth worrying about.

Cheers
Sam

Show
Sam Hemelryk added a comment - Awesome Eloy, I completely agree if we can auto close we should be! I've integrated this now and I suppose its just a case of making that change as some point, although hardly worth worrying about. Cheers Sam
Hide
Permalink
Ankit Agarwal added a comment - - edited

Hi Guys,
This works as expected.
Passing this issue.
Thanks

Show
Ankit Agarwal added a comment - - edited Hi Guys, This works as expected. Passing this issue. Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

icao_reverse('arreis olik rebemevon afla letoh ognat');

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: