Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31709

Delete message_get_participants() from message/lib.php

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      grep for message_get_participants and check that there are no calls to it.

      To be double sure, go to the messaging page and go through the various options in the messaging navigation drop down and just check that all is well.

      Show
      grep for message_get_participants and check that there are no calls to it. To be double sure, go to the messaging page and go through the various options in the messaging navigation drop down and just check that all is well.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-31709_message_get_participants

      Description

      There is a comment that says that message_get_participants() should be deleted in 2.2. Check its genuinely not being used and delete it.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              andyjdavis Andrew Davis added a comment -

              Adding a master branch and testing instructions. This probably only wants to go into master. According to the comment in the code it should have been removed in 2.2 but we still probably shouldnt delete a function from stable.

              Show
              andyjdavis Andrew Davis added a comment - Adding a master branch and testing instructions. This probably only wants to go into master. According to the comment in the code it should have been removed in 2.2 but we still probably shouldnt delete a function from stable.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Hi Andrew,
              Looks safe to delete it. Also I found a bunch of other functions that were supposed to be deleted before 2.2 , but were not deleted. Created MDL-31902 to handle with those functions.
              +1 to integrate.
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - Hi Andrew, Looks safe to delete it. Also I found a bunch of other functions that were supposed to be deleted before 2.2 , but were not deleted. Created MDL-31902 to handle with those functions. +1 to integrate. Thanks
              Hide
              andyjdavis Andrew Davis added a comment - - edited

              Submitting for integration. Probably only master only. Theoretically it could go into 2.2 stable however there is little to be gained.

              Show
              andyjdavis Andrew Davis added a comment - - edited Submitting for integration. Probably only master only. Theoretically it could go into 2.2 stable however there is little to be gained.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Some hours ago...

              the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              nebgor Aparup Banerjee added a comment -

              thanks, thats been integrated.

              And thanks for creating that issue Ankit, too many solo missions going on!

              Show
              nebgor Aparup Banerjee added a comment - thanks, thats been integrated. And thanks for creating that issue Ankit, too many solo missions going on!
              Hide
              nebgor Aparup Banerjee added a comment -

              passed! - no problems seen in drop down too

              Show
              nebgor Aparup Banerjee added a comment - passed! - no problems seen in drop down too
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              FCT (fixed, closing, thanks). Ciao

              "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
              ~ Benjamin Disraeli

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12