Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31710

webservice unit tests: add function scopes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      0) Requires admin access & having both the code-checker and the phpdoc-checker local plugins installed.

      1) Run the code-checker against 'webservice/simpletest/testwebservice.php'.
      2) TEST: No errors are returned, only a few warnings about some comments potentially being code (with some %).

      3) Run the phpdoc-checker against 'webservice/simpletest/testwebservice.php'.
      4) No error/warnings are returned.

      Show
      0) Requires admin access & having both the code-checker and the phpdoc-checker local plugins installed. 1) Run the code-checker against 'webservice/simpletest/testwebservice.php'. 2) TEST: No errors are returned, only a few warnings about some comments potentially being code (with some %). 3) Run the phpdoc-checker against 'webservice/simpletest/testwebservice.php'. 4) No error/warnings are returned.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      All functions of the web service unit test class miss their scope (public, protected, private). Add them (mainly public): /webservice/simpletest/testwebservice.php

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            jerome Jérôme Mouneyrac
            Integrator:
            Sam Hemelryk
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12