Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31719

Allow theme change on url now works without brackets

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Themes
    • Environment:
      anyt
    • Database:
      MySQL
    • Testing Instructions:
      Hide
      1. Login as Admin
      2. go to Site Administration > Appearance > Theme setting
      3. TEST that the description information alongside the option to "Allow theme change by URL" reads relatively clearly and not ambiguous or misleading in its presentation.
      Show
      Login as Admin go to Site Administration > Appearance > Theme setting TEST that the description information alongside the option to "Allow theme change by URL" reads relatively clearly and not ambiguous or misleading in its presentation.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31719_master

      Description

      Interface states use:

      theme=

      {themename}

      Now works with:

      ?theme=themename

      Interface instructions need updating

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ray Ray Lawrence added a comment -

            Added Gerry as watcher

            Show
            ray Ray Lawrence added a comment - Added Gerry as watcher
            Hide
            gerry Gerard Caulfield added a comment -

            Hi Ray, did you mean to add me or another Gerry?

            Show
            gerry Gerard Caulfield added a comment - Hi Ray, did you mean to add me or another Gerry?
            Hide
            ray Ray Lawrence added a comment -

            Added you as it's a language/interface issue.

            Show
            ray Ray Lawrence added a comment - Added you as it's a language/interface issue.
            Hide
            gerry Gerard Caulfield added a comment -

            Ah I see, thanks Ray

            Show
            gerry Gerard Caulfield added a comment - Ah I see, thanks Ray
            Hide
            lazydaisy Mary Evans added a comment -

            Hi Ray,
            Where exactly are you seeing that instruction? What interface? Is this a themes' issue or an administration one.

            Show
            lazydaisy Mary Evans added a comment - Hi Ray, Where exactly are you seeing that instruction? What interface? Is this a themes' issue or an administration one.
            Hide
            ray Ray Lawrence added a comment -

            Theme settings page.

            If the current model persists i.e. no brackets it's an admin/language issue.

            If it's reverted to the i.e. with brackets approach in the interface it's a themes issue.

            The current approach is simpler to effect so my vote is to simply change the Theme settings interface text.

            Show
            ray Ray Lawrence added a comment - Theme settings page. If the current model persists i.e. no brackets it's an admin/language issue. If it's reverted to the i.e. with brackets approach in the interface it's a themes issue. The current approach is simpler to effect so my vote is to simply change the Theme settings interface text.
            Hide
            lazydaisy Mary Evans added a comment -

            The proposal is to change the text to read:

            If enabled, the theme can be changed by adding either:<br />
            ?theme=themename to any Moodle URL (eg: mymoodlesite.com/?theme=afterburner)or<br />
            &theme=themename to any internal Moodle URL (eg: mymoodlesite.com/course/view.php?id=2&theme=afterburner)

            which I think makes it very clear.

            Show
            lazydaisy Mary Evans added a comment - The proposal is to change the text to read: If enabled, the theme can be changed by adding either:<br /> ?theme=themename to any Moodle URL (eg: mymoodlesite.com/?theme=afterburner)or<br /> &theme=themename to any internal Moodle URL (eg: mymoodlesite.com/course/view.php?id=2&theme=afterburner) which I think makes it very clear.
            Hide
            poltawski Dan Poltawski added a comment -

            I've integrated that now, thanks everyone!

            Show
            poltawski Dan Poltawski added a comment - I've integrated that now, thanks everyone!
            Hide
            ray Ray Lawrence added a comment -

            Thanks

            Show
            ray Ray Lawrence added a comment - Thanks
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Looks Good
            Thanks for fixing this Mary.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Looks Good Thanks for fixing this Mary.
            Hide
            lazydaisy Mary Evans added a comment - - edited

            You're welcome Rajesh, it was easy and I did not think I was stepping on anyone's toes in the process.

            Show
            lazydaisy Mary Evans added a comment - - edited You're welcome Rajesh, it was easy and I did not think I was stepping on anyone's toes in the process.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            U P S T R E A M I Z E D !

            Many thanks for the hard work, closing this as fixed.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12