Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31739

forum_get_email_message_id() is missing a doc block

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forum
    • Labels:

      Description

      forum_get_email_message_id() needs documenting. note that it only exists in master.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              andyjdavis Andrew Davis created issue -
              andyjdavis Andrew Davis made changes -
              Field Original Value New Value
              Assignee moodle.com [ moodle.com ] Andrew Davis [ andyjdavis ]
              andyjdavis Andrew Davis made changes -
              Link This issue discovered while testing MDL-30698 [ MDL-30698 ]
              andyjdavis Andrew Davis made changes -
              Fix Version/s STABLE Sprint 18 [ 11650 ]
              salvetore Michael de Raadt made changes -
              Labels triaged
              Hide
              andyjdavis Andrew Davis added a comment -

              Something like...

              /**
               * Create a message-id string to use in forum notification email custom headers
               * 
               * message-id is used by email clients to identify emails and to nest conversations
               *
               * @param int $postid The ID of the forum post we are notifying the user about
               * @param int $usertoid The ID of the user being notified
               * @param string $hostname The server's hostname
               * @return string A unique message-id
               */
              forum_get_email_message_id($postid, $usertoid, $hostname)

              Show
              andyjdavis Andrew Davis added a comment - Something like... /** * Create a message-id string to use in forum notification email custom headers * * message-id is used by email clients to identify emails and to nest conversations * * @param int $postid The ID of the forum post we are notifying the user about * @param int $usertoid The ID of the user being notified * @param string $hostname The server's hostname * @return string A unique message-id */ forum_get_email_message_id($postid, $usertoid, $hostname)
              andyjdavis Andrew Davis made changes -
              Status Open [ 1 ] Development in progress [ 3 ]
              Hide
              andyjdavis Andrew Davis added a comment -

              Adding a branch. This fix is master only.

              Show
              andyjdavis Andrew Davis added a comment - Adding a branch. This fix is master only.
              andyjdavis Andrew Davis made changes -
              Pull Master Diff URL https://github.com/andyjdavis/moodle/compare/master...MDL-31739_forum_docblock
              Pull Master Branch https://github.com/andyjdavis/moodle/compare/master...MDL-31739_forum_docblock
              Testing Instructions Just check that the doc block is present in /mod/forum/lib.php.
              Pull from Repository git://github.com/andyjdavis/moodle.git
              andyjdavis Andrew Davis made changes -
              Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
              andyjdavis Andrew Davis made changes -
              gerry Gerard Caulfield made changes -
              Original Estimate 0 minutes [ 0 ]
              Remaining Estimate 0 minutes [ 0 ]
              Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
              Peer reviewer gerry
              Hide
              gerry Gerard Caulfield added a comment -

              Line 370 has a trailing space.

              "Create a message-id string to use in forum notification email custom headers" may be a little difficult to interpret due to the "forum notification email custom headers" phrase running together.
              You may wish to split it up like so:
              "Create a message-id string to use in the custom headers of forum notification emails."
              ...or something along those lines. Up to you though. Good fix.

              Show
              gerry Gerard Caulfield added a comment - Line 370 has a trailing space. "Create a message-id string to use in forum notification email custom headers" may be a little difficult to interpret due to the "forum notification email custom headers" phrase running together. You may wish to split it up like so: "Create a message-id string to use in the custom headers of forum notification emails." ...or something along those lines. Up to you though. Good fix.
              gerry Gerard Caulfield made changes -
              Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
              Hide
              andyjdavis Andrew Davis added a comment -

              Removed the trailing space and went with your suggested reworking. Submitting for integration.

              Show
              andyjdavis Andrew Davis added a comment - Removed the trailing space and went with your suggested reworking. Submitting for integration.
              andyjdavis Andrew Davis made changes -
              Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
              nebgor Aparup Banerjee made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Integrator nebgor
              Hide
              nebgor Aparup Banerjee added a comment -

              This looks good to integrate in coming cycle.

              Show
              nebgor Aparup Banerjee added a comment - This looks good to integrate in coming cycle.
              nebgor Aparup Banerjee made changes -
              Status Integration review in progress [ 10004 ] Waiting for integration review [ 10010 ]
              nebgor Aparup Banerjee made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Currently in integration Yes [ 10041 ]
              Hide
              nebgor Aparup Banerjee added a comment -

              integrated and passing.

              Show
              nebgor Aparup Banerjee added a comment - integrated and passing.
              nebgor Aparup Banerjee made changes -
              Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
              Fix Version/s 2.3 [ 10657 ]
              Hide
              nebgor Aparup Banerjee added a comment -

              passing this non-code change.

              Show
              nebgor Aparup Banerjee added a comment - passing this non-code change.
              nebgor Aparup Banerjee made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              Tester nebgor
              nebgor Aparup Banerjee made changes -
              Status Testing in progress [ 10011 ] Tested [ 10006 ]
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Well,

              I wish I said it every time
              you do the things you do.
              You always lend a helping hand,
              and I'm filled with gratitude.

              You are strong and generous
              for each and everyone one of us.
              I am eternally grateful,
              I cannot say thanks enough.

              Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Tested [ 10006 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]
              Currently in integration Yes [ 10041 ]
              Integration date 01/Mar/12
              stronk7 Eloy Lafuente (stronk7) made changes -
              Fix Version/s STABLE Sprint 18 [ 11650 ]

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12