Moodle
  1. Moodle
  2. MDL-31749

Afterburner theme adds padding to scorm window

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      install the demo scorm package "DemoMoodle22SCORM.zip" attached to MDL-31381 (using either upload or url download funtion) in a running 2.2Stable build as a scorm activity, use the "new window" setting with size as 970, 770.
      check to make sure the padding shown in the screenshot attached isn't there.

      Show
      install the demo scorm package "DemoMoodle22SCORM.zip" attached to MDL-31381 (using either upload or url download funtion) in a running 2.2Stable build as a scorm activity, use the "new window" setting with size as 970, 770. check to make sure the padding shown in the screenshot attached isn't there.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-31749
    • Rank:
      38346

      Description

      There are still some white space extra padding in scorm window (when used new window setting)
      Refer http://tracker.moodle.org/browse/MDL-31381?focusedCommentId=145402&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-145402 for further reference.

      Thanks

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          was there a particular theme you were using when you saw this? - it doesn't seem to be a prob with "standard" theme? - unless it's browser specific? - which browser were you using?

          thanks!

          Show
          Dan Marsden added a comment - was there a particular theme you were using when you saw this? - it doesn't seem to be a prob with "standard" theme? - unless it's browser specific? - which browser were you using? thanks!
          Hide
          Dan Marsden added a comment -

          just tried afterburner - big spaces there.....

          Show
          Dan Marsden added a comment - just tried afterburner - big spaces there.....
          Hide
          Dan Marsden added a comment -

          yeah - afterburner sets a 90% page-wrapper... we probably need to add this to scorm css to override it.

          #page-mod-scorm-player.pagelayout-popup #page-wrapper

          {width:100%;}
          Show
          Dan Marsden added a comment - yeah - afterburner sets a 90% page-wrapper... we probably need to add this to scorm css to override it. #page-mod-scorm-player.pagelayout-popup #page-wrapper {width:100%;}
          Hide
          Ankit Agarwal added a comment -

          Hi Dan,
          Yeah I was using afterburner.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Dan, Yeah I was using afterburner. Thanks
          Hide
          Dan Marsden added a comment -

          NOTE TO INTEGRATOR: this is for 22Stable and master only - not 21Stable.

          Show
          Dan Marsden added a comment - NOTE TO INTEGRATOR: this is for 22Stable and master only - not 21Stable.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Marsden added a comment -

          rebased

          Show
          Dan Marsden added a comment - rebased
          Hide
          Sam Hemelryk added a comment -

          Thanks Dan your changes have been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Dan your changes have been integrated now
          Hide
          Adrian Greeve added a comment -

          Tested in a few different browsers. Everything is working as it should.
          Many thanks.

          Show
          Adrian Greeve added a comment - Tested in a few different browsers. Everything is working as it should. Many thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

          icao_reverse('arreis olik rebemevon afla letoh ognat');
          

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: