Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31753

Community finder uses wrong courseid when in "My Moodle" context

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Prerequesite:

      • You need a user who has an ID which doens't have a matching coursed to demonstrate the problem. (you might need to delete a few courses, or create a few users to this)
      • Its easiest to assign this user as an admin for testing
      1. Login as aforementioned user
      2. Visit yourmoodle/my/
      3. Add the community finder block to mymoodle page
      4. Click on the search button in the block
      5. VERIFY: that a search form comes up without errors
      6. Add the community finder block to the front page
      7. Click on the search button in the block
      8. VERIFY: that a search form comes up without errors
      Show
      Prerequesite: You need a user who has an ID which doens't have a matching coursed to demonstrate the problem. (you might need to delete a few courses, or create a few users to this) Its easiest to assign this user as an admin for testing Login as aforementioned user Visit yourmoodle/my/ Add the community finder block to mymoodle page Click on the search button in the block VERIFY: that a search form comes up without errors Add the community finder block to the front page Click on the search button in the block VERIFY: that a search form comes up without errors
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE

      Description

      Community finder block creates a link to search interface that includes courseid argument. The value for courseid is wrong when block is added to "My Moodle" page - it equals to userid instead of "1".

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Added testing instructions and submitting for integration.

            Tomasz, if you are able to rebase this on the latest 22_STABLE it'd be helpful.

            INTEGRATOR: Can be cherry-picked to 23 and master.

            Show
            poltawski Dan Poltawski added a comment - Added testing instructions and submitting for integration. Tomasz, if you are able to rebase this on the latest 22_STABLE it'd be helpful. INTEGRATOR: Can be cherry-picked to 23 and master.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (22, 23 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
            Hide
            tmuras Tomasz Muras added a comment - - edited

            Hi, I just came back - I see that you don't need re-basing for 22_STABLE anymore?

            Show
            tmuras Tomasz Muras added a comment - - edited Hi, I just came back - I see that you don't need re-basing for 22_STABLE anymore?
            Hide
            poltawski Dan Poltawski added a comment -

            No, thanks Tomasz - it cherry-picked cleanly (I imagine).

            Show
            poltawski Dan Poltawski added a comment - No, thanks Tomasz - it cherry-picked cleanly (I imagine).
            Hide
            phalacee Jason Fowler added a comment -

            All good Dan

            Show
            phalacee Jason Fowler added a comment - All good Dan
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Fixed STOP Closed STOP Thanks STOP

            Yay, imagination! Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12