"Start at last page seen" function broken in Moodle 2

Thanks for reporting that and providing a potential solution.

Looks good
+1 to integrate!

Thanks Ankit for reviewing.

Submitting for integration review.

It took me a while to understand how this fixed the bug - then I spotted this was a for loop only running once through the array! Wow!

Thanks Rosie, that has been integrated now!

Tested on moodle 22

the Start at last page seen feature works OK now, but with debug ON I'm getting these errors:

Notice: Trying to get property of non-object in moodle\mod\lesson\view.php on line 198

Notice: Trying to get property of non-object in moodle\mod\lesson\view.php on line 201

I suggest adding the following condition:

if ($attempt) {
	        $jumpto = $DB->get_field('lesson_answers', 'jumpto', array('id' => $attempt->answerid));
	        // convert the jumpto to a proper page id
	        if ($jumpto == 0) { // unlikely value!
	            $lastpageseen = $attempt->pageid;
	        } elseif ($jumpto == LESSON_NEXTPAGE) {
	            if (!$lastpageseen = $DB->get_field('lesson_pages', 'nextpageid', array('id' => $attempt->pageid))) {
	                // no nextpage go to end of lesson
	                $lastpageseen = LESSON_EOL;
	            }
	        } else {
	            $lastpageseen = $jumpto;
	        }
        }

Hi Joseph,

Thank you for testing the issue. I've created a new issue to fix the notice errors (MDL-32195).

Just marking this as failed to reset the process

I've pushed the fixes the issues reported by Joseph as part of this issue.

So this issue is ready for testing again.

(I didn't do it in MDL-32195 as unfortunately the branches there didn't apply cleanly (as not on top of current integration branch).

thanks everyone

Just a quick note on accessibility - the "Yes" and "No" options presented to the user should probably be buttons rather than links ...

Test passed perfectly in all the fixed-for versions of moodle

And this has landed upstream, finally! Yay!

תודה רבה && شكرا جزيلا

Closing, ciao

Where (in the file) do we put the patch Joseph suggests? Is the a specific line number? I have changed the ASC to DESC but clicking Yes does not allow the user to continue. Wondering if Joseph's patch is the key?

@David,
Which version of Moodle are you using?

The installation with the current issue is Moodle 2.1.2+ (Build: 20111019)

@David,
Any chance you could update to a more current version of Moodle (2.4) where the bug has been fixed?

That is in the works but still months in the future (new server required etc.) I was hoping this fix would work until then.

@David, the oldest version of Moodle on my test site that I can test this on is Moodle 2.1.7+ (Build: 20120719).
I do not see any problem, the Lesson "start at last page seen" function works as expected.
Surely you could at least upgrade to 2.1.7+, this is only a minor upgrade from 2.1.2.
Joseph

Upgrading is something I have ever done. Is this upgrade simple to do? I thought the fix or maybe even a copy of the php file in question from a newer version would work. I am more of an advanced user than anything and can muddle through some things like installations and configurations but upgrading? Would upgrading itself fix the problem?

I can't find a 2.1.7, would 2.1.10 be the wise choice? Also, I can't find any specific info on this upgrade. Any direction to the appropriate documentation?

Yes, go for 2.1.10.
Instructions for upgrade really depend on how you have installed your Moodle site in the first place.
Try the Moodle documentation or the General problems forum for help.

Ok. But before we try the upgrade, where in the php file (what line) do we put your patch? I would like to try that first because it seems easiest. If that doesn't work, we will look at the upgrade to 2.1.10 until we get our new server this summer.

@David,
I understand your problem but, since I no longer have that "old" moodle 2.1.2 version available I cannot test the patch I provided some time ago.
Can you confirm that you are getting the problem I reported first in this bug report? Can you describe it?

The problem I have is when you click on yes, you are not taken back to your page last seen. You are taken back to page 2 (sometimes page 4) (out of a possible 34 pages) in the tests I conducted on my lesson. I can't see why the tests returned me back to different pages other than maybe one test having correct answers and one test having incorrect answers.

I followed the first patch and changed ASC to DESC with no change. I thought your additional patch would help as the comments after your patch on the tracker all said the problem was resolved.

Joseph, I upgraded to 2.1.10. It went pretty smoothly.

I tested the lesson. No change. I did discover something though. With the line in lessonlib.php set to ASC, the participant is always sent back to page 5 of 33. With the line set to DESC, the participant is sent back to page 10 of 33.

My lesson has a question on every page, some are multiple choice, some are multiple-answer multiple choice, and some are matching. The pages the participant is brought back to are both matching questions, regardless of exiting the lesson on a multiple choice or matching question.

I don't know what to do here. Is it the matching questions? Also, I notice your test says "select the right answer" Does selecting the wrong answer have something to do with it?

@David, the best I can do at this stage is to experiment with your own Lesson instance.
Please do the following:
Go to the course where your 33-question Lesson exists and back-up that course, making sure to un-tick everything except that Lesson; do NOT include users in the back-up.
Send me the export file so I can restore and test it on my moodle 2.1 local test site.
Send to moodle@rezeau.org and then we can continue the discussion through e-mail.
Joseph