Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1/ disable text caching us usually
      2/ run lib/simpletest/testhtmlpurifier.php tests
      3/ enable full debug and click around your site and verify system logs for notices and warnings

      Show
      1/ disable text caching us usually 2/ run lib/simpletest/testhtmlpurifier.php tests 3/ enable full debug and click around your site and verify system logs for notices and warnings
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w10_MDL-31785_m23_htmlpurifier

      Gliffy Diagrams

        Issue Links

          Activity

          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          rex Rex Lorenzo added a comment -

          I wrote a unit test to test the problems with nested lists in Wikis

          function test_nested_lists() {    
              $text = "<ul><li>One<ul><li>Two</li></ul></li><li>Three</li></ul>";        
              $this->assertIdentical($text, purify_html($text));
          }

          But the unit test passes even in the current 2.2.1 and with the upgraded version of HTML Purifier. But I tested that on display in the Wiki the nested lists now properly display with this patch, but not in the regular 2.2.1.

          So not sure if you want to add this unit test because for some reason I cannot duplicate the bugs reported with a unit test.

          Show
          rex Rex Lorenzo added a comment - I wrote a unit test to test the problems with nested lists in Wikis function test_nested_lists() { $text = "<ul><li>One<ul><li>Two</li></ul></li><li>Three</li></ul>"; $this->assertIdentical($text, purify_html($text)); } But the unit test passes even in the current 2.2.1 and with the upgraded version of HTML Purifier. But I tested that on display in the Wiki the nested lists now properly display with this patch, but not in the regular 2.2.1. So not sure if you want to add this unit test because for some reason I cannot duplicate the bugs reported with a unit test.
          Hide
          skodak Petr Skoda added a comment -

          I have rebased it and improved the tests + added the nested list testing, thanks!

          Show
          skodak Petr Skoda added a comment - I have rebased it and improved the tests + added the nested list testing, thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (21, 22 & master. No 20).

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 & master. No 20).
          Hide
          rwijaya Rossiani Wijaya added a comment -

          This is working fine.

          Thanks for working on this.

          Test passed.

          Show
          rwijaya Rossiani Wijaya added a comment - This is working fine. Thanks for working on this. Test passed.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

          icao_reverse('arreis olik rebemevon afla letoh ognat');

          Closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12