Moodle

Formal white should give evidence of current tab and page

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.0.8, 2.1.5, 2.2.2
  • Component/s: Themes
  • Labels:
    None
  • Testing Instructions:
    Hide

    Go to a tab and choose a page in an activity using tabs.php
    Look at the displayed tabs.
    The name of the tab and the name of the page should appear in bold.

    Show
    Go to a tab and choose a page in an activity using tabs.php Look at the displayed tabs. The name of the tab and the name of the page should appear in bold.
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-31794_master
  • Pull Master Diff URL:

Description

Let me describe this issue with an example.
Suppose a user goes to tab = "Template" and page = "Single template" in database activity.
It would be nice if formal_white would give evidence of the "page" chosen by the user displaying in bold the current tab name and the current page name.
Looking at the two attachments you can better see what I mean.

  1. current.png
    26 kB
    28/Feb/12 12:40 AM
  2. next.png
    28 kB
    28/Feb/12 12:40 AM

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Daniele this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Daniele this has been integrated now.
Hide
Permalink
Ankit Agarwal added a comment -

This is working as expected!
Passing
Thanks

Show
Ankit Agarwal added a comment - This is working as expected! Passing Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

icao_reverse('arreis olik rebemevon afla letoh ognat');

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: