Moodle
  1. Moodle
  2. MDL-31805

lib/html2text.php file needs to be updated to latest maintained version

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:
      None
    • Rank:
      38427

      Description

      While looking at MDL-28896 that was fixing an issue with the library, i realised that the entire html2text library might need to be updated.
      Garett Gengler mentioned the file is kept up to date here

        Issue Links

          Activity

          Hide
          Aparup Banerjee added a comment -

          linking seed issue.

          Show
          Aparup Banerjee added a comment - linking seed issue.
          Hide
          Petr Škoda added a comment -

          thanks for the report, the modifications are now tracked in https://github.com/moodle/custom-html2text

          Show
          Petr Škoda added a comment - thanks for the report, the modifications are now tracked in https://github.com/moodle/custom-html2text
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Note we had already a bunch of tests @ testweblib.php . Surely it's worth unifying all them into the new test file.

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Note we had already a bunch of tests @ testweblib.php . Surely it's worth unifying all them into the new test file.
          Hide
          Petr Škoda added a comment -

          fixing, thanks!!

          Show
          Petr Škoda added a comment - fixing, thanks!!
          Hide
          Petr Škoda added a comment -

          one more commit added, it moves the tests from weblib and fixes test for <p>

          Show
          Petr Škoda added a comment - one more commit added, it moves the tests from weblib and fixes test for <p>
          Hide
          Petr Škoda added a comment -

          the change in tests was done because of upstream: revision 4722 Remove leading empty lines (can be produced by eg. P tag on the beginning)

          Show
          Petr Škoda added a comment - the change in tests was done because of upstream: revision 4722 Remove leading empty lines (can be produced by eg. P tag on the beginning)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Detected 3 unit-tests failing:

          1) 1 @ weblib, because of the leading "\n\n". Easy to fix.
          2) 2 @ question, because now <th> tags are handled and converted to upper lines, and they used to be discarded previously. And the other because the link texts are now handled and converted to upper lines. Used to be discarded too.

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Detected 3 unit-tests failing: 1) 1 @ weblib, because of the leading "\n\n". Easy to fix. 2) 2 @ question, because now <th> tags are handled and converted to upper lines, and they used to be discarded previously. And the other because the link texts are now handled and converted to upper lines. Used to be discarded too.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is the commit proposed to fix all those failing tests:

          https://github.com/stronk7/moodle/commit/6b6d7e185df7280649b4bcd5163a96746021f33a

          Sounds ok, Petr, Tim?

          Show
          Eloy Lafuente (stronk7) added a comment - This is the commit proposed to fix all those failing tests: https://github.com/stronk7/moodle/commit/6b6d7e185df7280649b4bcd5163a96746021f33a Sounds ok, Petr, Tim?
          Hide
          Petr Škoda added a comment -

          +1

          Show
          Petr Škoda added a comment - +1
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing, unittest execution both locally and by CI passing 100% again.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing, unittest execution both locally and by CI passing 100% again.
          Hide
          Tim Hunt added a comment -

          +1 from me.

          Show
          Tim Hunt added a comment - +1 from me.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FCT (fixed, closing, thanks). Ciao

          "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
          ~ Benjamin Disraeli

          Show
          Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: