Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31805

lib/html2text.php file needs to be updated to latest maintained version

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:
      None

      Description

      While looking at MDL-28896 that was fixing an issue with the library, i realised that the entire html2text library might need to be updated.
      Garett Gengler mentioned the file is kept up to date here

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            nebgor Aparup Banerjee added a comment -

            linking seed issue.

            Show
            nebgor Aparup Banerjee added a comment - linking seed issue.
            Hide
            skodak Petr Skoda added a comment -

            thanks for the report, the modifications are now tracked in https://github.com/moodle/custom-html2text

            Show
            skodak Petr Skoda added a comment - thanks for the report, the modifications are now tracked in https://github.com/moodle/custom-html2text
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited

            Note we had already a bunch of tests @ testweblib.php . Surely it's worth unifying all them into the new test file.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited Note we had already a bunch of tests @ testweblib.php . Surely it's worth unifying all them into the new test file.
            Hide
            skodak Petr Skoda added a comment -

            fixing, thanks!!

            Show
            skodak Petr Skoda added a comment - fixing, thanks!!
            Hide
            skodak Petr Skoda added a comment -

            one more commit added, it moves the tests from weblib and fixes test for <p>

            Show
            skodak Petr Skoda added a comment - one more commit added, it moves the tests from weblib and fixes test for <p>
            Hide
            skodak Petr Skoda added a comment -

            the change in tests was done because of upstream: revision 4722 Remove leading empty lines (can be produced by eg. P tag on the beginning)

            Show
            skodak Petr Skoda added a comment - the change in tests was done because of upstream: revision 4722 Remove leading empty lines (can be produced by eg. P tag on the beginning)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited

            Detected 3 unit-tests failing:

            1) 1 @ weblib, because of the leading "\n\n". Easy to fix.
            2) 2 @ question, because now <th> tags are handled and converted to upper lines, and they used to be discarded previously. And the other because the link texts are now handled and converted to upper lines. Used to be discarded too.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited Detected 3 unit-tests failing: 1) 1 @ weblib, because of the leading "\n\n". Easy to fix. 2) 2 @ question, because now <th> tags are handled and converted to upper lines, and they used to be discarded previously. And the other because the link texts are now handled and converted to upper lines. Used to be discarded too.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is the commit proposed to fix all those failing tests:

            https://github.com/stronk7/moodle/commit/6b6d7e185df7280649b4bcd5163a96746021f33a

            Sounds ok, Petr, Tim?

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is the commit proposed to fix all those failing tests: https://github.com/stronk7/moodle/commit/6b6d7e185df7280649b4bcd5163a96746021f33a Sounds ok, Petr, Tim?
            Hide
            skodak Petr Skoda added a comment -

            +1

            Show
            skodak Petr Skoda added a comment - +1
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passing, unittest execution both locally and by CI passing 100% again.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passing, unittest execution both locally and by CI passing 100% again.
            Hide
            timhunt Tim Hunt added a comment -

            +1 from me.

            Show
            timhunt Tim Hunt added a comment - +1 from me.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            FCT (fixed, closing, thanks). Ciao

            "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
            ~ Benjamin Disraeli

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12