Moodle
  1. Moodle
  2. MDL-31808

Upload assignment: Feedback is not shown to user when assignment is graded in gradebook level only

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Assignment (2.2)
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      To replicate the bug:

      1. Create upload assignment (advanced uploading of files)
      2. Login as user and submit assignment
      3. Login as admin/teacher, open course gradebook and grade the assignment
      4. Login as user, open assignment (mod/assignment/view.php?id=...) and see that feedback box with the grade is not shown
      Show
      To replicate the bug: Create upload assignment (advanced uploading of files) Login as user and submit assignment Login as admin/teacher, open course gradebook and grade the assignment Login as user, open assignment (mod/assignment/view.php?id=...) and see that feedback box with the grade is not shown
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31808-master-1

      Description

      Feedback is not shown to user when upload assignment is graded in gradebook level only.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Ruslan Kabalin added a comment -

            Point is that plugin-level view_feedback method is checking for 'timemarked' field in 'assignment_submissions' table, which is not updated in case if grading was done in gradebook level only. Like in the parent class 'assignment_base' this check is not required, as the feedback will be displayed despite whether it has been graded in gradebook or locally via assignment/submissions interface. The patch will come shortly.

            Show
            Ruslan Kabalin added a comment - Point is that plugin-level view_feedback method is checking for 'timemarked' field in 'assignment_submissions' table, which is not updated in case if grading was done in gradebook level only. Like in the parent class 'assignment_base' this check is not required, as the feedback will be displayed despite whether it has been graded in gradebook or locally via assignment/submissions interface. The patch will come shortly.
            Hide
            Ruslan Kabalin added a comment -

            Added patch

            Show
            Ruslan Kabalin added a comment - Added patch
            Hide
            Dan Poltawski added a comment -

            Again I am waiting for freed back from Petr on this

            Show
            Dan Poltawski added a comment - Again I am waiting for freed back from Petr on this
            Hide
            Dan Poltawski added a comment -

            Looks good - petr's feedback in the other issue seems to suggest this is OK

            Show
            Dan Poltawski added a comment - Looks good - petr's feedback in the other issue seems to suggest this is OK
            Hide
            Ruslan Kabalin added a comment -

            Can be cleanly cherry-picked to 2.x stable branches.

            Show
            Ruslan Kabalin added a comment - Can be cleanly cherry-picked to 2.x stable branches.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Some hours ago...

            the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Sam Hemelryk added a comment -

            Thanks Ruslan this has been integrated now

            Show
            Sam Hemelryk added a comment - Thanks Ruslan this has been integrated now
            Hide
            Michael de Raadt added a comment -

            Test result: Success.

            I'll have to create an issue (or look for one already created) so we can apply this to the other standard assignment types.

            Show
            Michael de Raadt added a comment - Test result: Success. I'll have to create an issue (or look for one already created) so we can apply this to the other standard assignment types.
            Hide
            Michael de Raadt added a comment -

            I've created MDL-32040 so that a similar change can be applied to the other assignment types.

            Show
            Michael de Raadt added a comment - I've created MDL-32040 so that a similar change can be applied to the other assignment types.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            FCT (fixed, closing, thanks). Ciao

            "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
            ~ Benjamin Disraeli

            Show
            Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: